Re: [Qemu-devel] Re: [PATCH 1/4] Add a scatter-gather list type and accessors

[Anthony Liguori <aliguori@us.ibm.com>]

M. Warner Losh wrote:
> In message: <4989FC3B.7010407@us.ibm.com>
>             Anthony Liguori <aliguori@us.ibm.com> writes:
> : Avi Kivity wrote:
> : > Anthony Liguori wrote:
> : >> Avi Kivity wrote:
> : >>> Scatter-gather lists are used extensively in dma-capable devices; a
> : >>> single data structure allows more code reuse later on.
> : >>>
> : >>> diff --git a/dma-helpers.c b/dma-helpers.c
> : >>> new file mode 100644
> : >>> index 0000000..315834e
> : >>> --- /dev/null
> : >>> +++ b/dma-helpers.c
> : >>> @@ -0,0 +1,29 @@
> : >>>   
> : >>
> : >> Needs copyright/license.
> : >
> : > Sure.
> : >
> : > Is it possible to have a blanket license for files which don't have 
> : > explicit terms?  I don't much like boilerplate.
> : 
> : I'd greatly prefer not to.  You can refer to a COPYING and we can have a 
> : default COPYING file but a copyright is really needed as far as I 
> : understand it.
>
> The copyright exists regardless of any notices being on the file.  In
> the absence of a license to copy, however, the default legally defined
> license is 'you may not copy it at all'.  Based on this, you need to
> have an explicit license for all files.  However, it only needs to be
> clear what the license for a given file is.  You don't have to have
> the license in each and every file.
>   

To put it quite simply, I can't take a patch that introduces a new file 
without a copyright/license in the header.  So there's no need to 
discuss it further than that :-)

Regards,

Anthony Liguori

> Warner
>