All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] dnet: driver for Dave DNET ethernet controller
Date: Thu, 05 Feb 2009 06:38:23 +0300	[thread overview]
Message-ID: <498A5F2F.1030603@emcraft.com> (raw)
In-Reply-To: <20090202202116.CF0BC8322908@gemini.denx.de>

Dear Wolfgang,

thanks for your review. I think I've addressed all your comments. Please
take a look on updated patches.

Wolfgang Denk wrote:
> I see. 
>
> Please do not operate on base register plus magic offset - implement a
> proper C structure instead to describe the controller hardware.
>   

I've done as you requested but I'm really in doubt why do you like it?
In the kernel offsets are preferred over C structures... And there is
nothing magical in offsets actually... we usually have offsets in specs
not C structures...

Regards, Ilya.

  reply	other threads:[~2009-02-05  3:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-02 15:44 [U-Boot] [PATCH 0/3] qong: support for Dave/DENX QongEVB-LITE Ilya Yanok
2009-02-02 15:44 ` [U-Boot] [PATCH 1/3] mx31: add GPIO registers definitions Ilya Yanok
2009-02-02 20:11   ` Wolfgang Denk
2009-02-02 15:44 ` [U-Boot] [PATCH 2/3] dnet: driver for Dave DNET ethernet controller Ilya Yanok
2009-02-02 17:31   ` Ben Warren
2009-02-02 17:36     ` Ilya Yanok
2009-02-02 20:21   ` Wolfgang Denk
2009-02-05  3:38     ` Ilya Yanok [this message]
2009-02-05 21:32       ` Wolfgang Denk
2009-02-11 19:40         ` Ilya Yanok
2009-02-02 15:44 ` [U-Boot] [PATCH 3/3] qong: support for Dave/DENX QongEVB-LITE board Ilya Yanok
2009-02-02 20:43   ` Wolfgang Denk
2009-02-05  3:43     ` Ilya Yanok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498A5F2F.1030603@emcraft.com \
    --to=yanok@emcraft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.