From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LV8Su-0004ki-3Z for mharc-grub-devel@gnu.org; Thu, 05 Feb 2009 12:56:40 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LV8Ss-0004jH-3m for grub-devel@gnu.org; Thu, 05 Feb 2009 12:56:38 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LV8Sq-0004hQ-Hy for grub-devel@gnu.org; Thu, 05 Feb 2009 12:56:37 -0500 Received: from [199.232.76.173] (port=46380 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LV8Sq-0004hH-DO for grub-devel@gnu.org; Thu, 05 Feb 2009 12:56:36 -0500 Received: from fg-out-1718.google.com ([72.14.220.152]:43139) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LV8Sp-0000kD-Q2 for grub-devel@gnu.org; Thu, 05 Feb 2009 12:56:36 -0500 Received: by fg-out-1718.google.com with SMTP id l27so266601fgb.30 for ; Thu, 05 Feb 2009 09:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type; bh=HdzYerzh83xvS1klL8vN8uP48k+HZc5hk9diVIK07sQ=; b=Doka4MWSqpIwHZSP4p+UzZBlTgCTX3+gRbSaBog6EjMuaA02msOKDpVjeKyq8L8NXu LtL1lpyJsAoeIDSUdrez0LNwPaxoTAPomCEwc9jPLWco9RsHfBLxngTb5ISR7w/zM2dH jk7f084nVuyq1ZAOyDLjoS1FMmG+sR7mqFxF4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; b=oMhV7qSSxZxYzNz7kHC+tmjxlBPY3YStQuozZGfVkRviNOtcaQp4MPhpILdJPFAWLg IHZqQEpq8E4O1GreWDu464iTG99E1dG9NGWYdkrMjpILDmWrYVxGjcdU7rXvSWPLJjhK i3MFnw4VX3p5URHf99qKdA0KmdJSZiXqlr9LA= Received: by 10.86.82.16 with SMTP id f16mr476078fgb.32.1233856594145; Thu, 05 Feb 2009 09:56:34 -0800 (PST) Received: from ?192.168.1.25? (173-91.62-81.cust.bluewin.ch [81.62.91.173]) by mx.google.com with ESMTPS id 3sm368138fge.22.2009.02.05.09.56.33 (version=SSLv3 cipher=RC4-MD5); Thu, 05 Feb 2009 09:56:33 -0800 (PST) Message-ID: <498B2850.1090008@gmail.com> Date: Thu, 05 Feb 2009 18:56:32 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 Content-Type: multipart/mixed; boundary="------------070509050105060306040302" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Bugfix] vbetest doesn't return to text mode X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Feb 2009 17:56:38 -0000 This is a multi-part message in MIME format. --------------070509050105060306040302 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hello. In text mode bits_per_pixel isn't set. Because of it grub_vbe_set_video_mode refuses to go back to text mode after vbetest command. Here is a bugfix Thanks Vladimir 'phcoder' Serbinenko --------------070509050105060306040302 Content-Type: text/x-diff; name="vbefix.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="vbefix.diff" Index: video/i386/pc/vbe.c =================================================================== --- video/i386/pc/vbe.c (revision 1973) +++ video/i386/pc/vbe.c (working copy) @@ -215,6 +215,8 @@ case 15: framebuffer.bytes_per_pixel = 2; break; case 8: framebuffer.bytes_per_pixel = 1; break; default: + if (mode <= 3 || mode == 7) + break; grub_vbe_bios_set_mode (old_mode, 0); return grub_error (GRUB_ERR_BAD_DEVICE, "cannot set VBE mode %x", Index: ChangeLog =================================================================== --- ChangeLog (revision 1973) +++ ChangeLog (working copy) @@ -1,3 +1,10 @@ +2009-02-05 Vladimir Serbinenko + + Don't check bits_per_pixel in text mode + + * video/i386/pc/vbe.c (grub_vbe_set_video_mode): Don't check + bits_per_pixel in text mode + 2009-02-04 Felix Zielcke util/getroot.c (grub_util_get_grub_dev): Add support for /dev/mdNpN and --------------070509050105060306040302--