From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] dm-path-selector: fix refcount corruption
Date: Fri, 06 Feb 2009 10:04:08 +0900 [thread overview]
Message-ID: <498B8C88.4010201@ce.jp.nec.com> (raw)
In-Reply-To: <D61CE787-206C-439C-AAB1-4EEFE5C7FF51@redhat.com>
Hi Jonathan,
Jonathan Brassow wrote:
> On Feb 5, 2009, at 6:51 AM, Jun'ichi Nomura wrote:
>
>> @@ -136,11 +126,6 @@ int dm_unregister_path_selector(struct p
>> return -EINVAL;
>> }
>>
>> - if (psi->use) {
>> - up_write(&_ps_lock);
>> - return -ETXTBSY;
>> - }
>> -
>> list_del(&psi->list);
>
>
> We still need this in some form, don't we? Like 'if (module_refcount...'?
I don't think so.
dm_unregister_path_selector() is called from module_exit function. So it is called when the refcount is 0.
Thanks,
--
Jun'ichi Nomura, NEC Corporation
prev parent reply other threads:[~2009-02-06 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 12:51 [PATCH] dm-path-selector: fix refcount corruption Jun'ichi Nomura
2009-02-05 21:48 ` Jonathan Brassow
2009-02-06 1:04 ` Jun'ichi Nomura [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498B8C88.4010201@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.