From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LVRHo-0001ee-BT for mharc-grub-devel@gnu.org; Fri, 06 Feb 2009 09:02:28 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVJrs-0004pf-CN for grub-devel@gnu.org; Fri, 06 Feb 2009 01:07:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVJrq-0004on-41 for grub-devel@gnu.org; Fri, 06 Feb 2009 01:07:11 -0500 Received: from [199.232.76.173] (port=36235 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVJrp-0004ok-OF for grub-devel@gnu.org; Fri, 06 Feb 2009 01:07:09 -0500 Received: from fg-out-1718.google.com ([72.14.220.158]:10400) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LVJrp-0007KE-7G for grub-devel@gnu.org; Fri, 06 Feb 2009 01:07:09 -0500 Received: by fg-out-1718.google.com with SMTP id l27so417956fgb.30 for ; Thu, 05 Feb 2009 22:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=NGJcTrJ/cIQhkJkTIyUfPvaiF5E/oUIqvvt01zAEu6M=; b=l8Sv43hJiyoNEAsW57zttiey6la08rq04aSUx8IdO9NOUzVYggN+1T+my0Ig5TzXIF 61CXVUponNGnIzAQzsWuylonbUcVzAVDfZRNbZJK35VpUSUSqUC4CrXninnavLKutE48 G97FzA+HqPgSfaU5RxGhU8YPUNR4250SxHh4U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=IiCYWnK1KTY/zbot+wnxJ7ZgFl/0e6GGjAjlsOYZDd6yxkEAlrEh4+ay4Ryc9TP/xx DvmH/S8KyKLQX08VlKbl4MaL7TUVapY9T4fOxOGxDzK3t7KBQWfPuK4vDfV3ZujbnJwG cKgOzce8XI+f/L7+ibg2zzdrYtB0IDF+AVsLc= Received: by 10.86.100.19 with SMTP id x19mr775241fgb.18.1233900426631; Thu, 05 Feb 2009 22:07:06 -0800 (PST) Received: from ?192.168.1.25? (89-139.62-81.cust.bluewin.ch [81.62.139.89]) by mx.google.com with ESMTPS id 3sm2434339fge.42.2009.02.05.22.07.05 (version=SSLv3 cipher=RC4-MD5); Thu, 05 Feb 2009 22:07:06 -0800 (PST) Message-ID: <498BD389.60902@gmail.com> Date: Fri, 06 Feb 2009 07:07:05 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 References: <1233866360.3426.31.camel@fz.local> In-Reply-To: <1233866360.3426.31.camel@fz.local> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] try to avoid false positives on FAT filesystem X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2009 06:07:12 -0000 If I understood you correctly you propose to use partition table information to determine filesystem. I'm personally against it. First of all it isn't portable - it probably wouldn't work on GPT. Second if you just do mkfs.* the partition type isn't changed. Linux ignores partition type and so if your patch is applied there will be many bug reports like "hey, *FS isn't detected". Finally sometimes you intentionally change partition type in the technics like partition hiding. IMO the correct solution to this problem is to make sure that fat and ntfs are probed at last. Should we add a priority field for this? Thanks Vladimir 'phcoder' Serbinenko Felix Zielcke wrote: > Here's a little patch to check if > bpb.version_specific.fat12_or_fat16.fstype or > bpb.version_specific.fat32.fstype has the string FAT12/FAT16/FAT32 > As can be seen on [0] and [1] Dell PCs have a small FAT partition > containing some utilities. > It seems like mkfs.ext2 isn't always clearing the first 512 bytes. > Good for us is that fstype is set to .AT16 on these Dell partitions, so > it can be easily avoided. > Are there any objections? > > [0] http://bugs.debian.org/514263 > [1] http://bugs.debian.org/505137