All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Seidel <frank@f-seidel.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Frank Seidel <fseidel@suse.de>,
	linux kernel <linux-kernel@vger.kernel.org>,
	akpm@linux-foundation.org,
	"David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
	jarod@redhat.com
Subject: Re: [PATCH] crypto: add missing KERN_* constants to printks
Date: Fri, 06 Feb 2009 15:54:38 +0100	[thread overview]
Message-ID: <498C4F2E.1070204@f-seidel.de> (raw)
In-Reply-To: <20090206145838.GA28197@x200.localdomain>

Alexey Dobriyan schrieb:
> On Fri, Feb 06, 2009 at 03:19:10PM +0100, Frank Seidel wrote:
>> According to kerneljanitors todo list all printk calls (beginning
>> a new line) should have an according KERN_* constant.
> 
> Forget about kernel janitors todo list, fix a bug instead.

Sure, i am eager to get my hands dirty in the kernel ;-),
but i needed to start somewhere and everybody told me
that the janitors todo list would be good place to start.

>> Those are the missing pieces here for the crypto subsystem.
> 
> You're inserting KERN_WARNING everywhere, what for?

Because every new line should have KERN_* constant and
KERN_WARNING is default/doesn't change current printout
behaviour.

Thanks,
Frank

  reply	other threads:[~2009-02-06 14:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-06 14:19 [PATCH] crypto: add missing KERN_* constants to printks Frank Seidel
2009-02-06 14:58 ` Alexey Dobriyan
2009-02-06 14:54   ` Frank Seidel [this message]
2009-02-06 15:03     ` Alexey Dobriyan
2009-02-06 14:59       ` Frank Seidel
2009-02-07 12:52         ` Herbert Xu
2009-02-07 14:13           ` Frank Seidel
2009-02-07 15:19 ` [PATCHv2] " Frank Seidel
2009-02-10  6:23   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498C4F2E.1070204@f-seidel.de \
    --to=frank@f-seidel.de \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=fseidel@suse.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarod@redhat.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.