All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: [PATCH] libkvm: Fix return of kvm_commit_irq_routes
Date: Fri, 06 Feb 2009 18:55:20 +0100	[thread overview]
Message-ID: <498C7988.7010604@siemens.com> (raw)
In-Reply-To: <498C76AF.3090306@siemens.com>

Jan Kiszka wrote:
> This patch kills the last warnings (caused by kvm changes) that I see on
> a x86-64 host when building x86_64-softmmu and also i386-softmmu without
> kvm.

Not true, I missed another new warning that could be more problematic
than the rest:

-------->

[PATCH] libkvm: Fix return of kvm_commit_irq_routes

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

 libkvm/libkvm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c
index 80300c9..92ffe10 100644
--- a/libkvm/libkvm.c
+++ b/libkvm/libkvm.c
@@ -1267,6 +1267,7 @@ int kvm_commit_irq_routes(kvm_context_t kvm)
 	r = ioctl(kvm->vm_fd, KVM_SET_GSI_ROUTING, kvm->irq_routes);
 	if (r == -1)
 		r = -errno;
+	return r;
 #else
 	return -ENOSYS;
 #endif

  reply	other threads:[~2009-02-06 17:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-06 17:43 [PATCH v2] kvm-userspace: Fix kvm-originated warnings Jan Kiszka
2009-02-06 17:55 ` Jan Kiszka [this message]
2009-02-08  9:55   ` [PATCH] libkvm: Fix return of kvm_commit_irq_routes Avi Kivity
2009-02-08  9:59 ` [PATCH v2] kvm-userspace: Fix kvm-originated warnings Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498C7988.7010604@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.