All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] Fix SIGSEGV crash in slirp networking code
Date: Fri, 06 Feb 2009 21:50:01 +0100	[thread overview]
Message-ID: <498CA279.401@mail.berlios.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]


Hello,

this patch fixes a bug which was introduced in r6288.
Please apply it to Qemu trunk.

See this discussion for details:

http://lists.gnu.org/archive/cgi-bin/namazu.cgi?query=Regression+in+networking+code+(SIGSEGV)&submit=Search&idxname=qemu-devel

Regards
Stefan Weil




[-- Attachment #2: slirp.patch --]
[-- Type: text/x-diff, Size: 615 bytes --]

Fix SIGSEGV crash in networking code (bug was introduced in r6288).
Thanks to Gleb Natapov for finding this fix.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Index: trunk/slirp/ip_input.c
===================================================================
--- trunk.orig/slirp/ip_input.c	2009-02-05 22:16:34.000000000 +0100
+++ trunk/slirp/ip_input.c	2009-02-05 22:17:02.000000000 +0100
@@ -392,8 +392,7 @@
 	 * into the new buffer.
 	 */
 	if (m->m_flags & M_EXT) {
-	  int delta;
-	  delta = (char *)ip - m->m_dat;
+	  int delta = (char *)q - m->m_dat;
 	  q = (struct ipasfrag *)(m->m_ext + delta);
 	}
 

             reply	other threads:[~2009-02-06 20:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-06 20:50 Stefan Weil [this message]
2009-02-06 21:38 ` [Qemu-devel] [PATCH] Fix SIGSEGV crash in slirp networking code Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498CA279.401@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.