From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LVvwt-0007UH-Pq for mharc-grub-devel@gnu.org; Sat, 07 Feb 2009 17:46:55 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVvwr-0007Tg-3b for grub-devel@gnu.org; Sat, 07 Feb 2009 17:46:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVvwn-0007TU-Vk for grub-devel@gnu.org; Sat, 07 Feb 2009 17:46:52 -0500 Received: from [199.232.76.173] (port=33637 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVvwn-0007TQ-OA for grub-devel@gnu.org; Sat, 07 Feb 2009 17:46:49 -0500 Received: from mailout08.t-online.de ([194.25.134.20]:45333) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LVvwn-0005cu-CK for grub-devel@gnu.org; Sat, 07 Feb 2009 17:46:49 -0500 Received: from fwd07.aul.t-online.de by mailout08.sul.t-online.de with smtp id 1LVvwj-0004ne-01; Sat, 07 Feb 2009 23:46:45 +0100 Received: from [10.3.2.2] (JOxZVYZHwh94aShNAqiYtA7Ofrg5KWwCZRV0qMTvJUVjkwsAhBY-kQ866JbP8GSw8e@[217.235.223.202]) by fwd07.aul.t-online.de with esmtp id 1LVvwc-1UYbeC0; Sat, 7 Feb 2009 23:46:38 +0100 Message-ID: <498E0F4F.6000503@t-online.de> Date: Sat, 07 Feb 2009 23:46:39 +0100 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11 MIME-Version: 1.0 To: The development of GRUB 2 References: <497B9D35.5010703@t-online.de> <20090207213813.GF6343@thorin> In-Reply-To: <20090207213813.GF6343@thorin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: JOxZVYZHwh94aShNAqiYtA7Ofrg5KWwCZRV0qMTvJUVjkwsAhBY-kQ866JbP8GSw8e X-TOI-MSGID: adf92707-6180-4a3c-af65-c2987cf6bdc1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] hdparm.mod - get/set ATA disk parameters X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Feb 2009 22:46:53 -0000 Robert Millan wrote: > On Sat, Jan 24, 2009 at 11:59:01PM +0100, Christian Franke wrote: > >> This patch adds a command which allows to change a few (S)ATA drive >> settings. It relies on a new pass-through function in ata.mod. >> > > Is this function going to be used for "normal" use of ata? Note that ata.mod > should be as small as possible, since coreboot users usually want to include > it the GRUB that is installed to flash. > > Like 'hdparm.mod' itself, the ATA pass-through function is not needed for normal boot. > Would it make sense to put the function elsewhere? > > I would suggest to move grub_ata_pass_through() to a new module (e.g. ata2.mod, atax.mod, ataex.mod, ...) The function should not be in hdparm.mod itself, because the hdparm command would also work with other ATA pass-through functions. For example with some future ahci.mod or even in conjunction with native USB support through a SAT tunnel. Christian