From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LVwFC-00089Q-P5 for mharc-grub-devel@gnu.org; Sat, 07 Feb 2009 18:05:50 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVwFA-00085C-GW for grub-devel@gnu.org; Sat, 07 Feb 2009 18:05:48 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVwF9-00083j-IC for grub-devel@gnu.org; Sat, 07 Feb 2009 18:05:47 -0500 Received: from [199.232.76.173] (port=36956 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVwF9-00083N-Ao for grub-devel@gnu.org; Sat, 07 Feb 2009 18:05:47 -0500 Received: from fg-out-1718.google.com ([72.14.220.156]:32058) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LVwF8-0007UQ-Pz for grub-devel@gnu.org; Sat, 07 Feb 2009 18:05:46 -0500 Received: by fg-out-1718.google.com with SMTP id l27so889879fgb.30 for ; Sat, 07 Feb 2009 15:05:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=uC+74SILvBg+Q2/b+kMD9gaSrU8f6QnBAXGjndbMd4E=; b=PEWWo4QXkvyc3Vava2vjxdOj7SuHa790V4c7N3xwIL5IkCEIXO+Lq9EMCnMPmHxEs4 wOYvj8VYEr6q3Mj22zASoPMVPINO9BLYV5gJb3sHkOaJhh0xn6T2xr3INsexFQvoGZEu 9UXrfvwJYZ9QyEKdop8/TrSZHWcbYFXjk/iNo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=op9t+M14+P03oxHkBCbczTMUI5cE88gNMcXyn5JryadarQS1CmbAe25SauDs1Cc5ci BlH2bEllpQaxZy7NgJ/xjykk4JwMttOZDXAYSvdmGZLuuVgJmcvDBS0iOZyvw9G5Usgd K9GJ/WUVCQJpI6d9Mv4rOxhZ3f268h/O/Macw= Received: by 10.86.51.10 with SMTP id y10mr1867041fgy.51.1234047945442; Sat, 07 Feb 2009 15:05:45 -0800 (PST) Received: from ?192.168.1.25? (27.67.202.62.cust.bluewin.ch [62.202.67.27]) by mx.google.com with ESMTPS id 4sm3457469fgg.35.2009.02.07.15.05.44 (version=SSLv3 cipher=RC4-MD5); Sat, 07 Feb 2009 15:05:45 -0800 (PST) Message-ID: <498E13C7.1000305@gmail.com> Date: Sun, 08 Feb 2009 00:05:43 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 References: <4981D1D4.2080102@gmail.com> <20090207221458.GM6343@thorin> In-Reply-To: <20090207221458.GM6343@thorin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Move BSD and multiboot boot helper out of the kernel to their respective modules X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Feb 2009 23:05:48 -0000 > This is small enough that it could make sense to use inline asm instead, > so we can avoid a separate file. What do you think? I agree with this. Actually in similar place in my xnu booting I used 4 lines of inline assembly. The only reason I kept it in .S is that I was in one of my lazy states. In few days I'll send two patches with your suggestions > Also, it'd be better if you can submit two separate patches, one for BSD > and one for Multiboot. Thanks Vladimir 'phcoder' Serbinenko