All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy White <jwhite@codeweavers.com>
To: git@vger.kernel.org
Subject: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.
Date: Sat, 07 Feb 2009 21:26:26 -0600	[thread overview]
Message-ID: <498E50E2.8050309@codeweavers.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]


Signed-off-by: Jeremy White <jwhite@codeweavers.com>
---
  Documentation/git-format-patch.txt |    4 +++-
  builtin-log.c                      |   15 +++++++++++++++
  2 files changed, 18 insertions(+), 1 deletions(-)



[-- Attachment #2: 7ed4bdd60ca12e71e1438defefbf83075b39a60b.diff --]
[-- Type: text/x-patch, Size: 1864 bytes --]

diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt
index 11a7d77..2e8e94e 100644
--- a/Documentation/git-format-patch.txt
+++ b/Documentation/git-format-patch.txt
@@ -174,7 +174,8 @@ CONFIGURATION
 -------------
 You can specify extra mail header lines to be added to each message
 in the repository configuration, new defaults for the subject prefix
-and file suffix, and number patches when outputting more than one.
+and file suffix, control attachements, and number patches when outputting
+more than one.
 
 ------------
 [format]
@@ -183,6 +184,7 @@ and file suffix, and number patches when outputting more than one.
 	suffix = .txt
 	numbered = auto
 	cc = <email>
+	attach [ = mime-boundary-string ]
 ------------
 
 
diff --git a/builtin-log.c b/builtin-log.c
index 2ae39af..c79895c 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -428,6 +428,8 @@ static const char *fmt_patch_suffix = ".patch";
 static int numbered = 0;
 static int auto_number = 1;
 
+static char *default_attach = NULL;
+
 static char **extra_hdr;
 static int extra_hdr_nr;
 static int extra_hdr_alloc;
@@ -488,6 +490,14 @@ static int git_format_config(const char *var, const char *value, void *cb)
 		auto_number = auto_number && numbered;
 		return 0;
 	}
+	if (!strcmp(var, "format.attach")) {
+		if (value && *value)
+			default_attach = xstrdup(value);
+		else
+			default_attach = xstrdup(git_version_string);
+		return 0;
+	}
+
 
 	return git_log_config(var, value, cb);
 }
@@ -787,6 +797,11 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
 
 	rev.subject_prefix = fmt_patch_subject_prefix;
 
+	if (default_attach) {
+		rev.mime_boundary = default_attach;
+		rev.no_inline = 1;
+	}
+
 	/*
 	 * Parse the arguments before setup_revisions(), or something
 	 * like "git format-patch -o a123 HEAD^.." may fail; a123 is


             reply	other threads:[~2009-02-08  3:32 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-08  3:26 Jeremy White [this message]
2009-02-08  5:10 ` [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch Boyd Stephen Smith Jr.
2009-02-08 16:01   ` Jeremy White
2009-02-08 17:28     ` Johannes Schindelin
2009-02-09 12:34       ` Michael J Gruber
2009-02-09 13:25         ` Ben Bucksch
2009-02-09 13:36           ` Johannes Schindelin
2009-02-09 13:50             ` Michael J Gruber
2009-02-09 14:39               ` Boyd Stephen Smith Jr.
2009-02-09 13:52             ` Ben Bucksch
2009-02-09 14:49               ` Johannes Schindelin
2009-02-09 13:52             ` Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.) Jeremy White
2009-02-09 14:18               ` Ben Bucksch
2009-02-09 15:38                 ` Jeremy White
2009-02-09 15:54                   ` Michael J Gruber
2009-02-09 16:24                     ` Ben Bucksch
2009-02-09 18:06                       ` Jeremy White
2009-02-09 18:54                       ` Brandon Casey
2009-02-09 19:09                         ` Ben Bucksch
2009-02-09 19:14                           ` Johannes Schindelin
2009-02-09 19:20                             ` Ben Bucksch
2009-02-09 19:30                               ` Brandon Casey
2009-02-09 19:51                                 ` Ben Bucksch
2009-02-09 19:59                                   ` Ben Bucksch
2009-02-09 21:03                                     ` Brandon Casey
2009-02-09 21:07                                       ` Brandon Casey
2009-02-09 22:01                                       ` Ben Bucksch
2009-02-09 22:13                                         ` Brandon Casey
2009-02-09 22:25                                           ` Ben Bucksch
2009-02-09 22:28                                             ` Brandon Casey
2009-02-09 22:46                                               ` Ben Bucksch
2009-02-10  1:00                                                 ` Brandon Casey
2009-02-09 19:33                             ` Brandon Casey
2009-02-09 20:09                               ` Johannes Schindelin
2009-02-10 10:07                                 ` Michael J Gruber
2009-02-12  4:37                                   ` Thunderbird and patches Miles Bader
2009-02-12 10:07                                     ` Michael J Gruber
2009-02-09 19:22                           ` Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.) Brandon Casey
2009-02-09 19:00                       ` [PATCH] example patch corrupted by thunderbird Brandon Casey
2009-02-09 15:49                 ` Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.) Michael J Gruber
2009-02-09 22:39               ` Thunderbird and patches Ben Bucksch
2009-02-09 22:55                 ` Jeremy White
2009-02-09 23:01                   ` Ben Bucksch
2009-02-10  1:41 ` [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2009-02-12 15:51 Jeremy White
2009-02-12 21:01 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498E50E2.8050309@codeweavers.com \
    --to=jwhite@codeweavers.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.