From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1LW5KN-00038V-Ki
	for mharc-grub-devel@gnu.org; Sun, 08 Feb 2009 03:47:47 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LW5KL-00037d-Eg
	for grub-devel@gnu.org; Sun, 08 Feb 2009 03:47:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LW5KK-00037R-Fj
	for grub-devel@gnu.org; Sun, 08 Feb 2009 03:47:44 -0500
Received: from [199.232.76.173] (port=44292 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LW5KK-00037O-AN
	for grub-devel@gnu.org; Sun, 08 Feb 2009 03:47:44 -0500
Received: from mta-out.inet.fi ([195.156.147.13]:40428 helo=kirsi1.inet.fi)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <chaac@nic.fi>) id 1LW5KJ-0007on-Ql
	for grub-devel@gnu.org; Sun, 08 Feb 2009 03:47:44 -0500
Received: from [192.168.1.102] (84.248.105.254) by kirsi1.inet.fi (8.5.014)
	id 48FC5AC904CAB8BF for grub-devel@gnu.org;
	Sun, 8 Feb 2009 10:47:39 +0200
Message-ID: <498E9C26.40407@nic.fi>
Date: Sun, 08 Feb 2009 10:47:34 +0200
From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= <chaac@nic.fi>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <498E15D0.4090101@gmail.com>
In-Reply-To: <498E15D0.4090101@gmail.com>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
Subject: Re: [Bugfix] Characters disappearing in gfxterm
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Feb 2009 08:47:46 -0000

phcoder wrote:
> Hello. I've run into the bug that when editing menu entry in gfxterm
> characters disappear after cursor moves away from its position. Here is
> bugfix

I don't think this is a clean fix:

> Index: term/gfxterm.c
> ===================================================================
> --- term/gfxterm.c	(revision 1974)
> +++ term/gfxterm.c	(working copy)
> @@ -744,6 +744,8 @@
>    /* Render cursor to text layer.  */
>    grub_video_set_active_render_target (text_layer);
>    grub_video_fill_rect (color, x, y, width, height);
> +  if (! show)
> +    write_char ();
>    grub_video_set_active_render_target (GRUB_VIDEO_RENDER_TARGET_DISPLAY);
>  
>    /* Mark cursor to be redrawn.  */

It is not designed to work in there. I think modifying this needs
logical level approach and not ad hoc fix.