From: Boaz Harrosh <bharrosh@panasas.com>
To: Fuerst Lars <lars.fuerst@thomson.net>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
open-osd mailing-list <osd-dev@open-osd.org>
Subject: Re: [PATCH] libosd: Fix NULL dereference BUG when target is none OSD conformant
Date: Sun, 08 Feb 2009 16:09:13 +0200 [thread overview]
Message-ID: <498EE789.2010507@panasas.com> (raw)
In-Reply-To: <498EE637.3030800@panasas.com>
Boaz Harrosh wrote:
> Very old OSC's Target had a BUG in the Get/Set attributes where
> it was looking in the wrong places for attribute lists length.
> If used with the open-osd initiator, the initiator would dereference
> a NULL pointer when retrieving system_information attributes.
>
> Checks are added if retrieval of each attributes was successful
> before accessing them.
>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> ---
Lars I will need your Tested-by: ... here
I did not manage to run with your version of the target. It might crash
farther on now.
(Or if you can identify where on git://git.open-osd.org/osc-osd is the
point that best matches your version and I can test it here)
Thanks in advance
Boaz
next prev parent reply other threads:[~2009-02-08 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 14:03 [PATCH] libosd: Fix NULL dereference BUG when target is none OSD conformant Boaz Harrosh
2009-02-08 14:09 ` Boaz Harrosh [this message]
2009-02-08 16:00 ` Boaz Harrosh
2009-02-08 16:02 ` [PATCH version 2] libosd: Fix NULL dereference BUG when target is not " Boaz Harrosh
2009-02-16 13:18 ` [osd-dev] " Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498EE789.2010507@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=lars.fuerst@thomson.net \
--cc=linux-scsi@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.