From: Roel Kluin <roel.kluin@gmail.com>
To: dbrownell@users.sourceforge.net
Cc: spi-devel-general@lists.sourceforge.net,
lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] spi: limit reaches -1, tested 0
Date: Sun, 08 Feb 2009 15:18:40 +0100 [thread overview]
Message-ID: <498EE9C0.3010601@gmail.com> (raw)
With a postfix decrement limit will reach -1 rather than 0,
so the warning will not be issued.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c
index 269a55e..a4652f1 100644
--- a/drivers/spi/spi_imx.c
+++ b/drivers/spi/spi_imx.c
@@ -779,7 +779,7 @@ static irqreturn_t interrupt_transfer(struct driver_data *drv_data)
/* Read trailing bytes */
limit = loops_per_jiffy << 1;
- while ((read(drv_data) == 0) && limit--);
+ while ((read(drv_data) == 0) && --limit);
if (limit == 0)
dev_err(&drv_data->pdev->dev,
next reply other threads:[~2009-02-08 14:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 14:18 Roel Kluin [this message]
[not found] ` <498EE9C0.3010601-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-02-08 15:55 ` [PATCH] spi: limit reaches -1, tested 0 David Brownell
2009-02-08 15:55 ` David Brownell
[not found] ` <200902080755.26241.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-08 16:28 ` David Brownell
2009-02-08 16:28 ` David Brownell
[not found] ` <200902080828.49036.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-08 16:50 ` Roel Kluin
2009-02-08 16:50 ` Roel Kluin
[not found] ` <498F0D64.4040909-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-02-08 17:26 ` David Brownell
2009-02-08 17:26 ` David Brownell
2009-02-08 17:42 ` Mariusz Ceier
2009-02-08 17:42 ` Mariusz Ceier
[not found] ` <498F1979.1030104-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-02-08 17:46 ` Roel Kluin
2009-02-08 17:46 ` Roel Kluin
-- strict thread matches above, loose matches on Subject: below --
2009-01-31 11:33 Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498EE9C0.3010601@gmail.com \
--to=roel.kluin@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.