[Qemu-devel] Re: [PATCH 02/17] block: Improve bdrv_iterate

[Jan Kiszka <jan.kiszka@siemens.com>]

Anthony Liguori wrote:
> Jan Kiszka wrote:
>> Make bdrv_iterate more useful by passing the BlockDriverState to the
>> iterator instead of the device name.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>   
> 
>> ---
>>
>>  block.c   |    4 ++--
>>  block.h   |    3 ++-
>>  monitor.c |    3 ++-
>>   
> 
> $ grep -l bdrv_iterate *.c hw/*.c
> block.c
> monitor.c
> qemu-img.c
> vl.c
> 
> So this patch will break the build.

$ grep -l "bdrv_iterate(" *.c hw/*.c
block.c
monitor.c

Unless I'm totally blind, all users have been converted (there's only
one). And it still builds for all targets and tools.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux