From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
the arch/x86 maintainers <x86@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, pgtable.h: fix 2-level 32-bit build
Date: Mon, 09 Feb 2009 09:25:54 -0800 [thread overview]
Message-ID: <49906722.3060905@goop.org> (raw)
In-Reply-To: <20090209110009.GA26517@elte.hu>
Ingo Molnar wrote:
> Please double check the fix below.
>
> Regarding the page.h include - maybe we should introduce asm/page_types.h just for
> the bare essentials? OTOH ... x86 asm/page.h already seems bare essentials.
>
> Regarding types, each include file should be self-sufficient.
>
I did some more work on this last night, resulting in the series below.
It introduces a series of *-defs.h headers which define constants and
very simple inlines without any complex external dependencies (they
depend on either other asm/*-defs.h headers, or basic common headers
like linux/types.h).
The following changes since commit fd95fb02f7ac3c96f2a8db4a8f0a04fdc4db5731:
Jeremy Fitzhardinge (1):
Include linux/mmzone to avoid cyclic dependency
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git x86/untangle
Jeremy Fitzhardinge (9):
Revert "Include linux/mmzone to avoid cyclic dependency"
Split pgtable.h into pgtable-defs.h and pgtable.h
Split pgtable_32.h into pgtable_32.h and pgtable_32-defs.h
Split pgtable_64.h into pgtable_64-defs.h and pgtable_64.h
Include pgtable_32|64-defs.h in pgtable-defs.h
create -defs.h counterparts for page*.h
x86: move 2 and 3 level asm-generic defs into page-defs
x86: move defs around to allow paravirt.h to just include page-defs.h
define pud_flags and pud_large properly to allow non-PAE builds
arch/x86/include/asm/page-defs.h | 155 ++++++++++++++++++++++
arch/x86/include/asm/page.h | 145 +--------------------
arch/x86/include/asm/page_32-defs.h | 92 +++++++++++++
arch/x86/include/asm/page_32.h | 89 +------------
arch/x86/include/asm/page_64-defs.h | 105 +++++++++++++++
arch/x86/include/asm/page_64.h | 101 +--------------
arch/x86/include/asm/paravirt.h | 2 +-
arch/x86/include/asm/pgtable-defs.h | 226 ++++++++++++++++++++++++++++++++
arch/x86/include/asm/pgtable.h | 223 +------------------------------
arch/x86/include/asm/pgtable_32-defs.h | 46 +++++++
arch/x86/include/asm/pgtable_32.h | 42 +------
arch/x86/include/asm/pgtable_64-defs.h | 46 +++++++
arch/x86/include/asm/pgtable_64.h | 48 +-------
drivers/char/hvc_xen.c | 1 -
14 files changed, 686 insertions(+), 635 deletions(-)
create mode 100644 arch/x86/include/asm/page-defs.h
create mode 100644 arch/x86/include/asm/page_32-defs.h
create mode 100644 arch/x86/include/asm/page_64-defs.h
create mode 100644 arch/x86/include/asm/pgtable-defs.h
create mode 100644 arch/x86/include/asm/pgtable_32-defs.h
create mode 100644 arch/x86/include/asm/pgtable_64-defs.h
J
prev parent reply other threads:[~2009-02-09 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <498CCFB5.3000706@goop.org>
2009-02-09 10:22 ` git pull: x86 header unification Ingo Molnar
2009-02-09 10:33 ` [PATCH] x86: early_printk.c - fix pgtable.h unification fallout Ingo Molnar
2009-02-09 10:44 ` [PATCH] x86, pgtable.h: macro-ify *_page() methods Ingo Molnar
2009-02-09 11:00 ` [PATCH] x86, pgtable.h: fix 2-level 32-bit build Ingo Molnar
2009-02-09 17:25 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49906722.3060905@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.