From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1LWhuy-0003OW-GD
	for mharc-grub-devel@gnu.org; Mon, 09 Feb 2009 21:00:08 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LWhuw-0003OD-Mv
	for grub-devel@gnu.org; Mon, 09 Feb 2009 21:00:06 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LWhuu-0003O1-Sb
	for grub-devel@gnu.org; Mon, 09 Feb 2009 21:00:06 -0500
Received: from [199.232.76.173] (port=41674 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LWhuu-0003Ny-LL
	for grub-devel@gnu.org; Mon, 09 Feb 2009 21:00:04 -0500
Received: from elasmtp-dupuy.atl.sa.earthlink.net ([209.86.89.62]:34304)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <magicpage91@earthlink.net>) id 1LWhuu-0007F2-7U
	for grub-devel@gnu.org; Mon, 09 Feb 2009 21:00:04 -0500
Received: from [24.148.247.139] (helo=[192.168.0.199])
	by elasmtp-dupuy.atl.sa.earthlink.net with esmtpa (Exim 4.67)
	(envelope-from <magicpage91@earthlink.net>) id 1LWhut-0005lw-SU
	for grub-devel@gnu.org; Mon, 09 Feb 2009 21:00:03 -0500
Message-ID: <4990E097.2060204@earthlink.net>
Date: Mon, 09 Feb 2009 21:04:07 -0500
From: BandiPat <magicpage91@earthlink.net>
Organization: Magic Page Products
User-Agent: Thunderbird 2.0.0.19 (X11/20081209)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <498E15D0.4090101@gmail.com> <498E9C26.40407@nic.fi>
In-Reply-To: <498E9C26.40407@nic.fi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
X-ELNK-Trace: c85a64c14a050764b95206241ab561599ef193a6bfc3dd481a732e67b63a6837dc8f436c36d41b938498dd5c8d2f0fb0350badd9bab72f9c350badd9bab72f9c
X-Originating-IP: 24.148.247.139
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6
Subject: Re: [Bugfix] Characters disappearing in gfxterm
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Feb 2009 02:00:07 -0000

Vesa J=C3=A4=C3=A4skel=C3=A4inen wrote:
> phcoder wrote:
>> Hello. I've run into the bug that when editing menu entry in gfxterm
>> characters disappear after cursor moves away from its position. Here i=
s
>> bugfix
>=20
> I don't think this is a clean fix:
>=20
>> Index: term/gfxterm.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- term/gfxterm.c	(revision 1974)
>> +++ term/gfxterm.c	(working copy)
>> @@ -744,6 +744,8 @@
>>    /* Render cursor to text layer.  */
>>    grub_video_set_active_render_target (text_layer);
>>    grub_video_fill_rect (color, x, y, width, height);
>> +  if (! show)
>> +    write_char ();
>>    grub_video_set_active_render_target (GRUB_VIDEO_RENDER_TARGET_DISPL=
AY);
>> =20
>>    /* Mark cursor to be redrawn.  */
>=20
> It is not designed to work in there. I think modifying this needs
> logical level approach and not ad hoc fix.
>=20
>=20
> _______________________________________________

Has this fix been committed yet or is there further work to be done to=20
clean it up before applying it?

Pat