From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Morten P.D. Stevens" <mstevens@win-professional.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: warning in arch/x86/kernel/cpu/mtrr/generic.c:400 with 2.6.29-rc3 on IBM x3400
Date: Mon, 09 Feb 2009 18:40:13 -0800 [thread overview]
Message-ID: <4990E90D.30005@kernel.org> (raw)
In-Reply-To: <20090209234528.GA862@elte.hu>
Ingo Molnar wrote:
> * Morten P.D. Stevens <mstevens@win-professional.com> wrote:
>
>> Hi,
>>
>> Update:
>>
>> the same issue with a linux 2.6.28.4 kernel.
>>
>> [ 0.000000] ------------[ cut here ]------------
>> [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/generic.c:404 generic_get_mtrr+0xdf/0x119()
>> [ 0.000000] mtrr: your BIOS has set up an incorrect mask, fixing it up.
>
> buggy BIOS most likely. Had the kernel not fixed up the MTRRs you'd have
> a very slow and unhappy system now.
please try:
diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
index 0c0a455..7a359ce 100644
--- a/arch/x86/kernel/cpu/mtrr/generic.c
+++ b/arch/x86/kernel/cpu/mtrr/generic.c
@@ -397,7 +397,8 @@ static void generic_get_mtrr(unsigned int reg, unsigned long *base,
tmp |= ~((1<<(hi - 1)) - 1);
if (tmp != mask_lo) {
- WARN_ONCE(1, KERN_INFO "mtrr: your BIOS has set up an incorrect mask, fixing it up.\n");
+ printk(KERN_INFO "mtrr: BIOS set mask_lo: %x should be %x, fixing it up\n", mask_lo, tmp);
+ WARN_ONCE(1, KERN_INFO "mtrr: your BIOS has set up an incorrect mask.\n");
mask_lo = tmp;
}
}
next prev parent reply other threads:[~2009-02-10 2:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 1:43 warning in arch/x86/kernel/cpu/mtrr/generic.c:400 with 2.6.29-rc3 on IBM x3400 Morten P.D. Stevens
2009-02-09 15:50 ` Morten P.D. Stevens
2009-02-09 23:45 ` Ingo Molnar
2009-02-10 0:25 ` AW: warning in arch/x86/kernel/cpu/mtrr/generic.c:400 with2.6.29-rc3 " Morten P.D. Stevens
2009-02-10 2:40 ` Yinghai Lu [this message]
2009-02-10 16:21 ` warning in arch/x86/kernel/cpu/mtrr/generic.c:400 with 2.6.29-rc3 " Morten P.D. Stevens
2009-02-10 18:52 ` Yinghai Lu
2009-02-10 20:34 ` Morten P.D. Stevens
2009-02-10 20:45 ` Yinghai Lu
2009-02-10 21:19 ` Morten P.D. Stevens
2009-02-11 5:06 ` Yinghai Lu
2009-02-11 16:01 ` Morten P.D. Stevens
2009-02-11 18:52 ` Yinghai Lu
2009-03-29 16:03 ` Morten P.D. Stevens
2009-03-29 19:17 ` Yinghai Lu
2009-02-11 10:43 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4990E90D.30005@kernel.org \
--to=yinghai@kernel.org \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mstevens@win-professional.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.