All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Clements <paul.clements@steeleye.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	jnelson-kernel-bugzilla@jamponi.net, Pavel Machek <pavel@ucw.cz>,
	stable@kernel.org
Subject: Re: [PATCH 1/1] NBD: fix I/O hang on disconnected nbds
Date: Tue, 10 Feb 2009 16:53:33 -0500	[thread overview]
Message-ID: <4991F75D.7010100@steeleye.com> (raw)
In-Reply-To: <20090210133537.23b1779a.akpm@linux-foundation.org>

Andrew Morton wrote:
> On Mon, 09 Feb 2009 13:21:51 -0500
> Paul Clements <paul.clements@steeleye.com> wrote:

>> This problem was introduced by the new request handling thread code
>> ("NBD: allow nbd to be used locally", 3/2008), which entered into 
>> mainline around 2.6.25.
> 
> Seems that the patch applies to 2.6.26, but not to 2.6.25.

OK, couldn't remember the exact timeframe.

>> The fix, which is fairly simple, is to restore the check for lo->sock
>> being NULL in do_nbd_request. This causes I/O to an uninitialized nbd to
>> immediately fail with an I/O error, as it did prior to the introduction 
>> of this bug.
> 
> I marked this as needing backporting into 2.6.26.x, 2.6.27.x and
> 2.6.28.x.  OK?

Yes, that would be a good idea.

Thanks,
Paul



      reply	other threads:[~2009-02-10 21:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-09 18:21 [PATCH 1/1] NBD: fix I/O hang on disconnected nbds Paul Clements
2009-02-10 21:35 ` Andrew Morton
2009-02-10 21:53   ` Paul Clements [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4991F75D.7010100@steeleye.com \
    --to=paul.clements@steeleye.com \
    --cc=akpm@linux-foundation.org \
    --cc=jnelson-kernel-bugzilla@jamponi.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.