[Qemu-devel] Re: [PATCH] remove smaller slots if registering a bigger one

[Jan Kiszka <jan.kiszka@siemens.com>]

Avi Kivity wrote:
> Jan Kiszka wrote:
>>> Which is fine. I'd prefer it to be here, so we can analyse it case by
>>> case.
>>> The old memory code for kvm was totally messy, in part because we
>>> tried to
>>> hug the world at once, with some code paths that were almost never hit.
>>>
>>> Slot management can easily get very complicated. and trying to come up
>>> with a solution that accounts for all problems at once may backfire
>>> on us.
>>>
>>>     
>>
>> Well, then "fix" all users...
>>   
> 
> Making memory management in qemu symmetric (any
> cpu_register_physical_memory() must be followed by a
> cpu_unregister_physical_memory() with the same parameters) is a good idea.
> 

Then all devices should track their - potentially guest-defined -
mappings and revert them on reset? I think handling this in the lower
layer is more convenient.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux