From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm-devel <kvm@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Zachary Amsden <zach@vmware.com>
Subject: Re: KVM: guest: only batch user pte updates
Date: Wed, 11 Feb 2009 08:57:42 -0800 [thread overview]
Message-ID: <49930386.7070509@goop.org> (raw)
In-Reply-To: <4992BCD4.7040505@redhat.com>
Avi Kivity wrote:
> Jeremy Fitzhardinge wrote:
>>>
>>> Yes. It seems however that only set_pte_at/pte_update/_defer are
>>> used under significatly long lazy mmu sections (long as in number of
>>> updates). Is it worthwhile to bother (and risk) batching kernel pte
>>> updates ?
>>>
>>
>> Well, that depends on how expensive each update is. For something
>> like kunmap atomic, I think combining the clear+tlb flush probably is
>> worthwhile.
>
> I agree, kmap_atomic() is fairly common.
(Not that we're actually batching it at present; we need to work out
proper semantics for nesting batches...)
J
prev parent reply other threads:[~2009-02-11 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 21:45 KVM: guest: only batch user pte updates Marcelo Tosatti
2009-02-10 22:17 ` Jeremy Fitzhardinge
2009-02-10 22:41 ` Marcelo Tosatti
2009-02-10 23:14 ` Jeremy Fitzhardinge
2009-02-11 11:56 ` Avi Kivity
2009-02-11 16:57 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49930386.7070509@goop.org \
--to=jeremy@goop.org \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.