All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix build on Linux 5.3 for implicit fall through
Date: Mon, 29 Jul 2019 22:01:37 +0200	[thread overview]
Message-ID: <4993307.ozS7eDCDq7@xps> (raw)
In-Reply-To: <20190729123216.64601-1-ferruh.yigit@intel.com>

29/07/2019 14:32, Ferruh Yigit:
> build error:
> .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c:
>    In function ‘igbuio_pci_enable_interrupts’:
>    .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c:230:6:
>    error: this statement may fall through
>    [-Werror=implicit-fallthrough=]
>   230 |   if (pci_alloc_irq_vectors(udev->pdev, 1, 1, ....
> .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c:240:2:
>    note: here
>   240 |  case RTE_INTR_MODE_MSI:
>       |  ^~~~
> 
> The build error is caused by Linux kernel commit in 5.3 that enables the
> "-Wimplicit-fallthrough=3" gcc flag.
> Commit a035d552a93b ("Makefile: Globally enable fall-through warning")
> 
> To fix the error, either a gcc attribute can be provided [1] or a code
> comment with some defined syntax need to be provided [2], since there is
> already comments, updated them slightly to match the required syntax to
> fix the build error.
> 
> [1]
> "__attribute__ ((fallthrough));"
> 
> [2]
> [ \t.!]*([Ee]lse,? |[Ii]ntentional(ly)? )?
> fall(s | |-)?thr(ough|u)[ \t.!]*(-[^\n\r]*)?
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks




  reply	other threads:[~2019-07-29 20:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 12:32 [dpdk-dev] [PATCH] igb_uio: fix build on Linux 5.3 for implicit fall through Ferruh Yigit
2019-07-29 20:01 ` Thomas Monjalon [this message]
2019-09-24 18:25 ` Luca Boccassi
2019-09-26  7:56   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4993307.ozS7eDCDq7@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.