From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: sashiko-reviews@lists.linux.dev
Cc: Frank.Li@kernel.org, robh@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 2/8] ARM: dts: imx6ul: Add LVDS DT overlay for TQMa6ULxL
Date: Fri, 02 Oct 2026 11:44:55 +0200 [thread overview]
Message-ID: <4993405.mvXUDI8C0e@steina-w> (raw)
In-Reply-To: <20261002091447.0E8F51F00899@smtp.kernel.org>
Am Freitag, 2. Oktober 2026, 11:14:46 CEST schrieb sashiko-bot@kernel.org:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] kbuild: wrong base DTB for imx6ul-tqma6ul2l-mba6ulx-lvds-tm070jvhg33
> --
>
> commit 008daca5167f9a5874f9d9c4e80bdfc8d57fb2cc
> Author: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> ARM: dts: imx6ul: Add LVDS DT overlay for TQMa6ULxL
>
> This commit adds the LVDS DT overlay for the TQMa6ULxL board, reusing
> the overlay file from the TQMa6ULx board.
>
> > diff --git a/arch/arm/boot/dts/nxp/imx/Makefile b/arch/arm/boot/dts/nxp/imx/Makefile
> > index ea0799ba1893e..734d40b8d389c 100644
> > --- a/arch/arm/boot/dts/nxp/imx/Makefile
> > +++ b/arch/arm/boot/dts/nxp/imx/Makefile
> > @@ -421,8 +421,10 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
> > imx6ulz-bsh-smm-m2.dtb
> >
> > imx6ul-tqma6ul2-mba6ulx-lvds-tm070jvhg33-dtbs += imx6ul-tqma6ul2-mba6ulx.dtb imx6ul-tqma6ul2-mba6ulx-lvds-tm070jvhg33.dtbo
> > +imx6ul-tqma6ul2l-mba6ulx-lvds-tm070jvhg33-dtbs += imx6ul-tqma6ul2-mba6ulx.dtb imx6ul-tqma6ul2-mba6ulx-lvds-tm070jvhg33.dtbo
>
> [Severity: High]
> Should this use imx6ul-tqma6ul2l-mba6ulx.dtb as the base instead of
> imx6ul-tqma6ul2-mba6ulx.dtb?
>
> Using the non-L variant base DTB here for the TQMa6ULxL board might boot
> the board with incorrect hardware definitions.
That is correct and will be fixed in v2.
Best regards
Alexander
> >
> > dtb-$(CONFIG_SOC_IMX6UL) += imx6ul-tqma6ul2-mba6ulx-lvds-tm070jvhg33.dtb
> > +dtb-$(CONFIG_SOC_IMX6UL) += imx6ul-tqma6ul2l-mba6ulx-lvds-tm070jvhg33.dtb
>
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2026-10-02 9:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 8:14 [PATCH 0/8] Display support for TQMa6UL[L]x Alexander Stein
2026-10-02 8:14 ` [PATCH 1/8] ARM: dts: imx6ul: Add LVDS DT overlay for TQMa6ULx Alexander Stein
2026-10-02 14:37 ` Frank Li
2026-10-02 8:14 ` [PATCH 2/8] ARM: dts: imx6ul: Add LVDS DT overlay for TQMa6ULxL Alexander Stein
2026-10-02 9:14 ` sashiko-bot
2026-10-02 9:44 ` Alexander Stein [this message]
2026-10-02 8:14 ` [PATCH 3/8] ARM: dts: imx6ull: Add LVDS DT overlay for TQMa6ULLx Alexander Stein
2026-10-02 8:14 ` [PATCH 4/8] ARM: dts: imx6ull: Add LVDS DT overlay for TQMa6ULLxL Alexander Stein
2026-10-02 8:14 ` [PATCH 5/8] ARM: dts: imx6ul: Add parallel display DT overlay for TQMa6ULx Alexander Stein
2026-10-02 8:14 ` [PATCH 6/8] ARM: dts: imx6ul: Add parallel display DT overlay for TQMa6ULxL Alexander Stein
2026-10-02 8:14 ` [PATCH 7/8] ARM: dts: imx6ull: Add parallel display DT overlay for TQMa6ULLx Alexander Stein
2026-10-02 9:14 ` sashiko-bot
2026-10-02 9:52 ` Alexander Stein
2026-10-02 8:14 ` [PATCH 8/8] ARM: dts: imx6ull: Add parallel display DT overlay for TQMa6ULLxL Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4993405.mvXUDI8C0e@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.