All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: Tejun Heo <tj@kernel.org>, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: pass in pt_regs pointer for syscalls that need it (take 2)
Date: Wed, 11 Feb 2009 13:50:55 -0800	[thread overview]
Message-ID: <4993483F.8020809@zytor.com> (raw)
In-Reply-To: <1234388638-13663-1-git-send-email-brgerst@gmail.com>

Looks much better!

Brian Gerst wrote:
>  
>  #ifdef CONFIG_X86_32
> -/*
> - * Note: do not pass in pt_regs directly as with tail-call optimization
> - * GCC will incorrectly stomp on the caller's frame and corrupt user-space
> - * register state:
> - */
> -asmlinkage int sys_rt_sigreturn(unsigned long __unused)
> +int sys_rt_sigreturn(struct pt_regs *regs)
>  {
> -	struct pt_regs *regs = (struct pt_regs *)&__unused;
> -
>  	return do_rt_sigreturn(regs);
>  }
>  #else /* !CONFIG_X86_32 */

I observe with this sys_rt_sigreturn() is identical for both 32 and 64 
bits (since int == long for 32 bits.)  Furthermore, *both* are now no-op 
stubs around do_rt_sigreturn, so we can simply remove both stubs and 
change do_rt_sigreturn into sys_rt_sigreturn.

	-hpa

  reply	other threads:[~2009-02-11 21:51 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-10 14:51 [PATCH 0/3] x86: Fix pt_regs passed by value Brian Gerst
2009-02-10 14:51 ` [PATCH 1/3] x86: Use pt_regs pointer in do_device_not_available() Brian Gerst
2009-02-11  7:43   ` Tejun Heo
2009-02-11 10:13     ` Ingo Molnar
2009-02-11 14:34     ` Brian Gerst
2009-02-11 14:42       ` Tejun Heo
2009-02-11 14:46         ` Brian Gerst
2009-02-11 14:53           ` Tejun Heo
2009-02-10 14:51 ` [PATCH 2/3] x86: Pass in pt_regs pointer for syscalls that need it Brian Gerst
2009-02-11  7:41   ` Tejun Heo
2009-02-11 10:18     ` Ingo Molnar
2009-02-11 14:14       ` Tejun Heo
2009-02-11 14:31     ` Brian Gerst
2009-02-11 14:41       ` Tejun Heo
2009-02-11 14:43         ` Tejun Heo
2009-02-11 14:48         ` Tejun Heo
2009-02-11 14:58           ` Ingo Molnar
2009-02-11 14:59           ` Brian Gerst
2009-02-11 15:05             ` Tejun Heo
2009-02-11 15:10               ` Brian Gerst
2009-02-11 15:14                 ` Tejun Heo
2009-02-11 15:59                   ` Ingo Molnar
2009-02-12  1:12                     ` Tejun Heo
2009-02-11 15:01       ` Ingo Molnar
2009-02-11 17:52   ` H. Peter Anvin
2009-02-11 18:27     ` Brian Gerst
2009-02-11 19:50       ` H. Peter Anvin
2009-02-11 19:57         ` Brian Gerst
2009-02-11 20:00           ` H. Peter Anvin
2009-02-11 21:43   ` [PATCH] x86: pass in pt_regs pointer for syscalls that need it (take 2) Brian Gerst
2009-02-11 21:50     ` H. Peter Anvin [this message]
2009-02-11 22:06     ` H. Peter Anvin
2009-02-12 11:02       ` Ingo Molnar
2009-02-10 14:51 ` [PATCH 3/3] x86: Drop -fno-stack-protector after pt_regs fixes Brian Gerst
2009-02-11 11:42 ` [PATCH 0/3] x86: Fix pt_regs passed by value Ingo Molnar
2009-02-11 14:15   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4993483F.8020809@zytor.com \
    --to=hpa@zytor.com \
    --cc=brgerst@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.