Re: [patch for 2.6.29? 2/4] pata_amd: program FIFO

[Robert Hancock <hancockrwd@gmail.com>]

Jeff Garzik wrote:
> akpm@linux-foundation.org wrote:
>> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
>>
>> With 32bit PIO we can use the posted write buffers, but only for 32bit 
>> I/O
>> cycles.  This means we must disable the FIFO for ATAPI where a final 
>> 16bit
>> cycle may occur.
>>
>> Rework the FIFO logic so that we disable the FIFO then selectively
>> re-enable it when we set the timings on AMD devices.  Also fix a case
>> where we scribbled on PCI config 0x41 of Nvidia chips when we shouldn't.
>>
>> Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> 
> Pinged Alan on 2/2, no response.
> 
> This seems necessary... but too instrusive and not yet well tested 
> enough for 2.6.29-rc?

I think we either need this patch or turn 32-bit PIO off for this driver 
for 2.6.29. Without either, things may break.