From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:44618 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032454AbeEXKvl (ORCPT ); Thu, 24 May 2018 06:51:41 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 04/11] media: vsp1: Remove unused display list structure field Date: Thu, 24 May 2018 13:51:37 +0300 Message-ID: <4994134.peM4qCLYyD@avalon> In-Reply-To: <9266418a78e00b185bb5ff131b54f289c7d8b016.1525354194.git-series.kieran.bingham+renesas@ideasonboard.com> References: <9266418a78e00b185bb5ff131b54f289c7d8b016.1525354194.git-series.kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:15 EEST Kieran Bingham wrote: > The vsp1 reference in the vsp1_dl_body structure is not used. > Remove it. > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/vsp1/vsp1_dl.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_dl.c > b/drivers/media/platform/vsp1/vsp1_dl.c index ec6fc21fabe0..b23e88cda49f > 100644 > --- a/drivers/media/platform/vsp1/vsp1_dl.c > +++ b/drivers/media/platform/vsp1/vsp1_dl.c > @@ -44,7 +44,6 @@ struct vsp1_dl_entry { > * @list: entry in the display list list of bodies > * @free: entry in the pool free body list > * @pool: pool to which this body belongs > - * @vsp1: the VSP1 device > * @entries: array of entries > * @dma: DMA address of the entries > * @size: size of the DMA memory in bytes > @@ -58,7 +57,6 @@ struct vsp1_dl_body { > refcount_t refcnt; > > struct vsp1_dl_body_pool *pool; > - struct vsp1_device *vsp1; > > struct vsp1_dl_entry *entries; > dma_addr_t dma; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 04/11] media: vsp1: Remove unused display list structure field Date: Thu, 24 May 2018 13:51:37 +0300 Message-ID: <4994134.peM4qCLYyD@avalon> References: <9266418a78e00b185bb5ff131b54f289c7d8b016.1525354194.git-series.kieran.bingham+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id A9A446E01C for ; Thu, 24 May 2018 10:51:41 +0000 (UTC) In-Reply-To: <9266418a78e00b185bb5ff131b54f289c7d8b016.1525354194.git-series.kieran.bingham+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUaHVyc2RheSwgMyBNYXkg MjAxOCAxNjozNjoxNSBFRVNUIEtpZXJhbiBCaW5naGFtIHdyb3RlOgo+IFRoZSB2c3AxIHJlZmVy ZW5jZSBpbiB0aGUgdnNwMV9kbF9ib2R5IHN0cnVjdHVyZSBpcyBub3QgdXNlZC4KPiBSZW1vdmUg aXQuCj4gCj4gU2lnbmVkLW9mZi1ieTogS2llcmFuIEJpbmdoYW0gPGtpZXJhbi5iaW5naGFtK3Jl bmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KClJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxs YXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL21lZGlh L3BsYXRmb3JtL3ZzcDEvdnNwMV9kbC5jIHwgMiAtLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3Zz cDFfZGwuYwo+IGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZGwuYyBpbmRleCBl YzZmYzIxZmFiZTAuLmIyM2U4OGNkYTQ5Zgo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWVkaWEv cGxhdGZvcm0vdnNwMS92c3AxX2RsLmMKPiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Zz cDEvdnNwMV9kbC5jCj4gQEAgLTQ0LDcgKzQ0LDYgQEAgc3RydWN0IHZzcDFfZGxfZW50cnkgewo+ ICAgKiBAbGlzdDogZW50cnkgaW4gdGhlIGRpc3BsYXkgbGlzdCBsaXN0IG9mIGJvZGllcwo+ICAg KiBAZnJlZTogZW50cnkgaW4gdGhlIHBvb2wgZnJlZSBib2R5IGxpc3QKPiAgICogQHBvb2w6IHBv b2wgdG8gd2hpY2ggdGhpcyBib2R5IGJlbG9uZ3MKPiAtICogQHZzcDE6IHRoZSBWU1AxIGRldmlj ZQo+ICAgKiBAZW50cmllczogYXJyYXkgb2YgZW50cmllcwo+ICAgKiBAZG1hOiBETUEgYWRkcmVz cyBvZiB0aGUgZW50cmllcwo+ICAgKiBAc2l6ZTogc2l6ZSBvZiB0aGUgRE1BIG1lbW9yeSBpbiBi eXRlcwo+IEBAIC01OCw3ICs1Nyw2IEBAIHN0cnVjdCB2c3AxX2RsX2JvZHkgewo+ICAJcmVmY291 bnRfdCByZWZjbnQ7Cj4gCj4gIAlzdHJ1Y3QgdnNwMV9kbF9ib2R5X3Bvb2wgKnBvb2w7Cj4gLQlz dHJ1Y3QgdnNwMV9kZXZpY2UgKnZzcDE7Cj4gCj4gIAlzdHJ1Y3QgdnNwMV9kbF9lbnRyeSAqZW50 cmllczsKPiAgCWRtYV9hZGRyX3QgZG1hOwoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0 CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=