All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart De Schuymer <bdschuym@pandora.be>
To: Tino Keitel <tkeitel@innominate.com>
Cc: bart.de.schuymer@pandora.be,
	ebtables-devel@lists.sourceforge.net,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] fix source code corruption in ebtables Makefile
Date: Thu, 12 Feb 2009 21:22:29 +0100	[thread overview]
Message-ID: <49948505.1000700@pandora.be> (raw)
In-Reply-To: <20090211163142.GA28401@tkeitel002.bln.innominate.local>

Hi,

Thanks for the report. The problem was actually in the naming of the 
nflog init function, see the update in cvs.

cheers,
Bart

Tino Keitel schreef:
> Hi,
>
> the attached patch fixes source code corruption in the static: target
> of the ebtables userspace Makefile. The sed magic tries to clean up the
> modified source files, but fails. It ends up with this modifications:
>
> diff -ru ebtables-v2.0.8-2.orig/extensions/ebt_nflog.c
> ebtables-v2.0.8-2/extensions/ebt_nflog.c
> --- ebtables-v2.0.8-2.orig/extensions/ebt_nflog.c       2009-02-11
> 16:21:37.000000000 +0100
> +++ ebtables-v2.0.8-2/extensions/ebt_nflog.c    2009-02-11
> 17:22:58.000000000 +0100
> @@ -45,7 +45,7 @@
>                "in-kernel queue\n");
>  }
>  
> -static void nflog_init(struct ebt_entry_watcher *watcher)
> +static _init(struct ebt_entry_watcher *watcher)
>  {
>         struct ebt_nflog_info *info = (struct ebt_nflog_info
> *)watcher->data;
>  
> @@ -165,7 +165,7 @@
>         .name = "nflog",
>         .size = sizeof(struct ebt_nflog_info),
>         .help = nflog_help,
> -       .init = nflog_init,
> +       .init _init,
>         .parse = nflog_parse,
>         .final_check = nflog_final_check,
>         .print = nflog_print,
>
> With the patch, the Makefile makes a backup of the original files and
> restores it after compilation.
>
> Signed-off-by: Tino Keitel <tino.keitel@innominate.com>
>
>   


      parent reply	other threads:[~2009-02-12 20:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 16:31 [PATCH] fix source code corruption in ebtables Makefile Tino Keitel
2009-02-11 16:34 ` Tino Keitel
2009-02-12 20:22 ` Bart De Schuymer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49948505.1000700@pandora.be \
    --to=bdschuym@pandora.be \
    --cc=bart.de.schuymer@pandora.be \
    --cc=ebtables-devel@lists.sourceforge.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=tkeitel@innominate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.