From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] mm: disable preemption in apply_to_pte_range
Date: Thu, 12 Feb 2009 16:21:04 -0800 [thread overview]
Message-ID: <4994BCF0.30005@goop.org> (raw)
commit 79d9c90453a7bc9e7613ae889a97ff6b44ab8380
Author: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Date: Thu Feb 12 13:45:34 2009 -0800
mm: disable preemption in apply_to_pte_range
Lazy mmu mode needs preemption disabled, so if we're apply to
init_mm (which doesn't require any pte locks), then explicitly
disable preemption.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
diff --git a/mm/memory.c b/mm/memory.c
index baa999e..71b3fb8 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1710,9 +1710,11 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd,
pgtable_t token;
spinlock_t *uninitialized_var(ptl);
- pte = (mm == &init_mm) ?
- pte_alloc_kernel(pmd, addr) :
- pte_alloc_map_lock(mm, pmd, addr, &ptl);
+ if (mm == &init_mm) {
+ preempt_disable();
+ pte = pte_alloc_kernel(pmd, addr);
+ } else
+ pte = pte_alloc_map_lock(mm, pmd, addr, &ptl);
if (!pte)
return -ENOMEM;
@@ -1732,6 +1734,9 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd,
if (mm != &init_mm)
pte_unmap_unlock(pte-1, ptl);
+ else
+ preempt_enable();
+
return err;
}
next reply other threads:[~2009-02-13 0:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 0:21 Jeremy Fitzhardinge [this message]
2009-02-13 0:35 ` [PATCH] mm: disable preemption in apply_to_pte_range Jeremy Fitzhardinge
2009-02-13 0:55 ` Andrew Morton
2009-02-13 0:55 ` Andrew Morton
2009-02-13 1:39 ` Jeremy Fitzhardinge
2009-02-13 1:39 ` Jeremy Fitzhardinge
2009-02-13 11:48 ` Peter Zijlstra
2009-02-13 11:48 ` Peter Zijlstra
2009-02-13 13:30 ` Nick Piggin
2009-02-13 13:30 ` Nick Piggin
2009-02-13 14:16 ` Peter Zijlstra
2009-02-13 14:16 ` Peter Zijlstra
2009-02-13 14:30 ` Nick Piggin
2009-02-13 14:30 ` Nick Piggin
2009-02-13 14:38 ` Peter Zijlstra
2009-02-13 14:38 ` Peter Zijlstra
2009-02-13 17:41 ` Jeremy Fitzhardinge
2009-02-13 17:41 ` Jeremy Fitzhardinge
2009-02-14 9:46 ` Peter Zijlstra
2009-02-14 9:46 ` Peter Zijlstra
2009-02-13 17:24 ` Jeremy Fitzhardinge
2009-02-13 17:24 ` Jeremy Fitzhardinge
2009-02-14 9:56 ` Peter Zijlstra
2009-02-14 9:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4994BCF0.30005@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.