From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86 headers: include linux/types.h
Date: Fri, 13 Feb 2009 08:25:30 -0800 [thread overview]
Message-ID: <49959EFA.8040507@goop.org> (raw)
In-Reply-To: <20090213122724.GA2172@elte.hu>
Ingo Molnar wrote:
> Regarding the fixlet below - wouldnt PTE_FLAGS_MASK be better placed in
> pgtable_types.h ? It's specifically related to the pte format. OTOH we
> have a lot of PTE details in the page_*types.h files already.
>
No, you're right.
> The boundary between page_types.h and pgtable_types.h does not seem to
> be clear to me - what is the principle you followed?
>
Well, basically anything to do with the internals of a pte*_t go in
pgtable.h. PTE_*_MASK should go there too, and is an oversight (though
its on the margin because of its dependency on the page size/mask
definitions in page*.h).
J
next prev parent reply other threads:[~2009-02-13 16:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 23:23 [GIT PULL] clean header untangling Jeremy Fitzhardinge
2009-02-13 12:02 ` Ingo Molnar
2009-02-13 12:18 ` [PATCH] x86 headers: remove duplicate pud_large() definition Ingo Molnar
2009-02-13 12:23 ` [PATCH] x86 headers: include linux/types.h Ingo Molnar
2009-02-13 12:27 ` Ingo Molnar
2009-02-13 12:37 ` [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__ Ingo Molnar
2009-02-13 18:44 ` Jeremy Fitzhardinge
2009-02-13 18:49 ` Ingo Molnar
2009-02-13 18:52 ` Jeremy Fitzhardinge
2009-02-13 18:57 ` Ingo Molnar
2009-02-13 16:25 ` Jeremy Fitzhardinge [this message]
2009-02-13 18:09 ` [PATCH] x86 headers: include linux/types.h Ingo Molnar
2009-02-16 21:00 ` Jeremy Fitzhardinge
2009-02-13 18:52 ` Jeremy Fitzhardinge
2009-02-13 18:55 ` Ingo Molnar
2009-02-13 18:59 ` Jeremy Fitzhardinge
2009-02-13 20:05 ` Ingo Molnar
2009-02-13 18:57 ` Jaswinder Singh Rajput
2009-02-13 16:27 ` [PATCH] x86 headers: remove duplicate pud_large() definition Jeremy Fitzhardinge
2009-02-13 18:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49959EFA.8040507@goop.org \
--to=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.