From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output Date: Fri, 08 Nov 2019 15:06:44 +0100 Message-ID: <4996186.DxzAFJqeGu@diego> References: <20191107092945.15513-1-wambui.karugax@gmail.com> <20191107133851.GF63329@art_vandelay> <20191108124630.GA10207@wambui> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20191108124630.GA10207@wambui> Sender: linux-kernel-owner@vger.kernel.org To: Wambui Karuga Cc: Sean Paul , hjc@rock-chips.com, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org Hi, [it seems your Reply-To mail header is set strangely as Reply-To: 20191107133851.GF63329@art_vandelay which confuses my MTA] Am Freitag, 8. November 2019, 13:46:30 CET schrieb Wambui Karuga: > On Thu, Nov 07, 2019 at 08:38:51AM -0500, Sean Paul wrote: > > On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > > > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > > > DRM helper macro. > > > > > > The commit message should show the reason _why_ you are doing > > > this instead of just stating that you are doing this. > > > > > > It's not that dev_err is uncommon in drivers/gpu/drm. > > > > > > > It is uncommon (this is the sole instance) in rockchip, however. So it makes > > sense to convert the dev_* prints in rockchip to DRM_DEV for consistency. > > > > Wambui, could you also please convert the dev_warn instance as well? > > > Hey, Sean. > Trying to convert this dev_warn instance, but the corresponding DRM_WARN > macro does not take the dev parameter which seems to be useful in the > original output. > Should I still convert it to DRM_WARN without the hdmi->dev parameter? There exists DRM_DEV_ERROR, DRM_DEV_INFO and DRM_DEV_DEBUG to handle actual devices. Interestingly there is no DRM_DEV_WARN though. So depending on what Sean suggest another option would be to add the missing DRM_DEV_WARN and then use it to replace the dev_warn. Heiko > > Thanks, > wambui > > I'll apply this to drm-misc-next and expand on the commit message a bit. > > > > Thanks, > > > > Sean > > > > > $ git grep -w dev_err drivers/gpu/drm | wc -l > > > 1950 > > > $ git grep -w DRM_DEV_ERROR drivers/gpu/drm | wc -l > > > 756 > > > > > > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > > > [] > > > > @@ -916,7 +916,7 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev) > > > > } > > > > > > > > if (!dsi->cdata) { > > > > - dev_err(dev, "no dsi-config for %s node\n", np->name); > > > > + DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name); > > > > return -EINVAL; > > > > } > > > > > > > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49A9BFA372C for ; Fri, 8 Nov 2019 14:07:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B2BB21848 for ; Fri, 8 Nov 2019 14:07:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WY6QVyjE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B2BB21848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wh5NGkHt6x7A4R7PZ0t4rokx2/UcLeCEXn4EPZrgZpA=; b=WY6QVyjEsNtooV PVn+xnpd3w4jk0rck4mHU9+5+ZHTvLtTiIzSJUV/VCwlkFgkd6hYSg0LSHpZdm6BztQQpr5syHrGC rKtw6BbPAvnx4Lgb09t5jmLFFvPXOlPyLrXHVK8fDLYSOZrH6aoOa4rri1n3J0FEteU4aRkHQBsXb ZNfupqT8XTpQ75lmGLr0NNjCiX2YwmXfnWbNxHoOOgP7VvPumqyE0z/FCY4IUTrNu2qlGQP2hiTZh 003VE3KUn8CQV3a2jyW88+ALhZ3+v0C4cyxoWcg+7pro7B03XLFX4pdDqulb1JdPAZK6ZcrJ2hDBv ipuxwWbBYZu+TRiYIScA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT4v0-0006PG-Rp; Fri, 08 Nov 2019 14:07:18 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT4uu-0006O7-Mi; Fri, 08 Nov 2019 14:07:16 +0000 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iT4uS-0001Tu-Pp; Fri, 08 Nov 2019 15:06:44 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Wambui Karuga Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output Date: Fri, 08 Nov 2019 15:06:44 +0100 Message-ID: <4996186.DxzAFJqeGu@diego> In-Reply-To: <20191108124630.GA10207@wambui> References: <20191107092945.15513-1-wambui.karugax@gmail.com> <20191107133851.GF63329@art_vandelay> <20191108124630.GA10207@wambui> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191108_060714_848880_16F5DA3D X-CRM114-Status: GOOD ( 21.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, daniel@ffwll.ch, Sean Paul , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, [it seems your Reply-To mail header is set strangely as Reply-To: 20191107133851.GF63329@art_vandelay which confuses my MTA] Am Freitag, 8. November 2019, 13:46:30 CET schrieb Wambui Karuga: > On Thu, Nov 07, 2019 at 08:38:51AM -0500, Sean Paul wrote: > > On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > > > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > > > DRM helper macro. > > > > > > The commit message should show the reason _why_ you are doing > > > this instead of just stating that you are doing this. > > > > > > It's not that dev_err is uncommon in drivers/gpu/drm. > > > > > > > It is uncommon (this is the sole instance) in rockchip, however. So it makes > > sense to convert the dev_* prints in rockchip to DRM_DEV for consistency. > > > > Wambui, could you also please convert the dev_warn instance as well? > > > Hey, Sean. > Trying to convert this dev_warn instance, but the corresponding DRM_WARN > macro does not take the dev parameter which seems to be useful in the > original output. > Should I still convert it to DRM_WARN without the hdmi->dev parameter? There exists DRM_DEV_ERROR, DRM_DEV_INFO and DRM_DEV_DEBUG to handle actual devices. Interestingly there is no DRM_DEV_WARN though. So depending on what Sean suggest another option would be to add the missing DRM_DEV_WARN and then use it to replace the dev_warn. Heiko > > Thanks, > wambui > > I'll apply this to drm-misc-next and expand on the commit message a bit. > > > > Thanks, > > > > Sean > > > > > $ git grep -w dev_err drivers/gpu/drm | wc -l > > > 1950 > > > $ git grep -w DRM_DEV_ERROR drivers/gpu/drm | wc -l > > > 756 > > > > > > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > > > [] > > > > @@ -916,7 +916,7 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev) > > > > } > > > > > > > > if (!dsi->cdata) { > > > > - dev_err(dev, "no dsi-config for %s node\n", np->name); > > > > + DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name); > > > > return -EINVAL; > > > > } > > > > > > > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D81C5DF60 for ; Fri, 8 Nov 2019 14:07:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81CB02178F for ; Fri, 8 Nov 2019 14:07:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81CB02178F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF1A06F9A2; Fri, 8 Nov 2019 14:07:11 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id A970E6F9A2 for ; Fri, 8 Nov 2019 14:07:10 +0000 (UTC) Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iT4uS-0001Tu-Pp; Fri, 08 Nov 2019 15:06:44 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Wambui Karuga Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output Date: Fri, 08 Nov 2019 15:06:44 +0100 Message-ID: <4996186.DxzAFJqeGu@diego> In-Reply-To: <20191108124630.GA10207@wambui> References: <20191107092945.15513-1-wambui.karugax@gmail.com> <20191107133851.GF63329@art_vandelay> <20191108124630.GA10207@wambui> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Sean Paul , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191108140644.mFlW0dUnOre4oePJxFESIk6Z1LpE7K_TaEMvhfxppjA@z> SGksCgpbaXQgc2VlbXMgeW91ciBSZXBseS1UbyBtYWlsIGhlYWRlciBpcyBzZXQgc3RyYW5nZWx5 IGFzClJlcGx5LVRvOiAyMDE5MTEwNzEzMzg1MS5HRjYzMzI5QGFydF92YW5kZWxheQp3aGljaCBj b25mdXNlcyBteSBNVEFdCgpBbSBGcmVpdGFnLCA4LiBOb3ZlbWJlciAyMDE5LCAxMzo0NjozMCBD RVQgc2NocmllYiBXYW1idWkgS2FydWdhOgo+IE9uIFRodSwgTm92IDA3LCAyMDE5IGF0IDA4OjM4 OjUxQU0gLTA1MDAsIFNlYW4gUGF1bCB3cm90ZToKPiA+IE9uIFRodSwgTm92IDA3LCAyMDE5IGF0 IDAxOjU0OjIyQU0gLTA4MDAsIEpvZSBQZXJjaGVzIHdyb3RlOgo+ID4gPiBPbiBUaHUsIDIwMTkt MTEtMDcgYXQgMTI6MjkgKzAzMDAsIFdhbWJ1aSBLYXJ1Z2Egd3JvdGU6Cj4gPiA+ID4gUmVwbGFj ZSB0aGUgdXNlIG9mIHRoZSBkZXZfZXJyIG1hY3JvIHdpdGggdGhlIERSTV9ERVZfRVJST1IKPiA+ ID4gPiBEUk0gaGVscGVyIG1hY3JvLgo+ID4gPiAKPiA+ID4gVGhlIGNvbW1pdCBtZXNzYWdlIHNo b3VsZCBzaG93IHRoZSByZWFzb24gX3doeV8geW91IGFyZSBkb2luZwo+ID4gPiB0aGlzIGluc3Rl YWQgb2YganVzdCBzdGF0aW5nIHRoYXQgeW91IGFyZSBkb2luZyB0aGlzLgo+ID4gPiAKPiA+ID4g SXQncyBub3QgdGhhdCBkZXZfZXJyIGlzIHVuY29tbW9uIGluIGRyaXZlcnMvZ3B1L2RybS4KPiA+ ID4gCj4gPiAKPiA+IEl0IGlzIHVuY29tbW9uICh0aGlzIGlzIHRoZSBzb2xlIGluc3RhbmNlKSBp biByb2NrY2hpcCwgaG93ZXZlci4gU28gaXQgbWFrZXMKPiA+IHNlbnNlIHRvIGNvbnZlcnQgdGhl IGRldl8qIHByaW50cyBpbiByb2NrY2hpcCB0byBEUk1fREVWIGZvciBjb25zaXN0ZW5jeS4KPiA+ IAo+ID4gV2FtYnVpLCBjb3VsZCB5b3UgYWxzbyBwbGVhc2UgY29udmVydCB0aGUgZGV2X3dhcm4g aW5zdGFuY2UgYXMgd2VsbD8KPiA+IAo+IEhleSwgU2Vhbi4KPiBUcnlpbmcgdG8gY29udmVydCB0 aGlzIGRldl93YXJuIGluc3RhbmNlLCBidXQgdGhlIGNvcnJlc3BvbmRpbmcgRFJNX1dBUk4KPiBt YWNybyBkb2VzIG5vdCB0YWtlIHRoZSBkZXYgcGFyYW1ldGVyIHdoaWNoIHNlZW1zIHRvIGJlIHVz ZWZ1bCBpbiB0aGUKPiBvcmlnaW5hbCBvdXRwdXQuCj4gU2hvdWxkIEkgc3RpbGwgY29udmVydCBp dCB0byBEUk1fV0FSTiB3aXRob3V0IHRoZSBoZG1pLT5kZXYgcGFyYW1ldGVyPwoKVGhlcmUgZXhp c3RzIERSTV9ERVZfRVJST1IsIERSTV9ERVZfSU5GTyBhbmQgRFJNX0RFVl9ERUJVRyB0bwpoYW5k bGUgYWN0dWFsIGRldmljZXMuIEludGVyZXN0aW5nbHkgdGhlcmUgaXMgbm8gRFJNX0RFVl9XQVJO IHRob3VnaC4KClNvIGRlcGVuZGluZyBvbiB3aGF0IFNlYW4gc3VnZ2VzdCBhbm90aGVyIG9wdGlv biB3b3VsZCBiZSB0byBhZGQgdGhlCm1pc3NpbmcgRFJNX0RFVl9XQVJOIGFuZCB0aGVuIHVzZSBp dCB0byByZXBsYWNlIHRoZSBkZXZfd2Fybi4KCgpIZWlrbwoKCgo+IAo+IFRoYW5rcywKPiB3YW1i dWkKPiA+IEknbGwgYXBwbHkgdGhpcyB0byBkcm0tbWlzYy1uZXh0IGFuZCBleHBhbmQgb24gdGhl IGNvbW1pdCBtZXNzYWdlIGEgYml0Lgo+ID4gCj4gPiBUaGFua3MsCj4gPiAKPiA+IFNlYW4KPiA+ IAo+ID4gPiAkIGdpdCBncmVwIC13IGRldl9lcnIgZHJpdmVycy9ncHUvZHJtIHwgd2MgLWwKPiA+ ID4gMTk1MAo+ID4gPiAkIGdpdCBncmVwIC13IERSTV9ERVZfRVJST1IgZHJpdmVycy9ncHUvZHJt IHwgd2MgLWwKPiA+ID4gNzU2Cj4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2ktcm9ja2NoaXAuYyBiL2RyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9kdy1taXBpLWRzaS1yb2NrY2hpcC5jCj4gPiA+IFtdCj4gPiA+ID4gQEAgLTkxNiw3 ICs5MTYsNyBAQCBzdGF0aWMgaW50IGR3X21pcGlfZHNpX3JvY2tjaGlwX3Byb2JlKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gPiA+ID4gIAl9Cj4gPiA+ID4gIAo+ID4gPiA+ICAJaWYg KCFkc2ktPmNkYXRhKSB7Cj4gPiA+ID4gLQkJZGV2X2VycihkZXYsICJubyBkc2ktY29uZmlnIGZv ciAlcyBub2RlXG4iLCBucC0+bmFtZSk7Cj4gPiA+ID4gKwkJRFJNX0RFVl9FUlJPUihkZXYsICJu byBkc2ktY29uZmlnIGZvciAlcyBub2RlXG4iLCBucC0+bmFtZSk7Cj4gPiA+ID4gIAkJcmV0dXJu IC1FSU5WQUw7Cj4gPiA+ID4gIAl9Cj4gPiA+IAo+ID4gPiAKPiA+ID4gCj4gPiA+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+IGRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKPiA+ID4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+ ID4gCj4gCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=