From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LYJwP-0007rS-L6
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 07:48:17 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LYJwL-0007o5-VH
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 07:48:16 -0500
Received: from [199.232.76.173] (port=53117 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LYJwL-0007nX-OR
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 07:48:13 -0500
Received: from smtprelay0099.hostedemail.com ([216.40.44.99]:55794
	helo=smtprelay.hostedemail.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kressb@moose.net>) id 1LYJwL-0008BZ-DZ
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 07:48:13 -0500
Received: from filter.hostedemail.com (ff-bigip1 [10.5.19.254])
	by smtprelay01.hostedemail.com (Postfix) with SMTP id 64C7D1F54558
	for <qemu-devel@nongnu.org>; Sat, 14 Feb 2009 12:48:11 +0000 (UTC)
Received: from [192.168.2.184] (cpe-66-66-167-50.rochester.res.rr.com
	[66.66.167.50]) (Authenticated sender: kressb@moose.net)
	by omf04.hostedemail.com (Postfix) with ESMTP
	for <qemu-devel@nongnu.org>; Sat, 14 Feb 2009 12:48:11 +0000 (UTC)
Message-ID: <4996BD8A.2050807@moose.net>
Date: Sat, 14 Feb 2009 07:48:10 -0500
From: Brian Kress <kressb@moose.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------020406030206020905030803"
Subject: [Qemu-devel] [PATCH] Fix incorrect attempt to clear a flag in vnc.c
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is a multi-part message in MIME format.
--------------020406030206020905030803
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

In vnc.c in pixel_format_message, the code tries to clear the 
QEMU_ALLOCATED_FLAG
from the client display surface, however it uses the wrong operator and 
ends up enabling all
other flags.  Most notably this enables the big endian flag and causes 
some chaos. 


--------------020406030206020905030803
Content-Type: text/plain;
 name="patch.flagfix"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="patch.flagfix"

Index: vnc.c
===================================================================
--- vnc.c	(revision 6619)
+++ vnc.c	(working copy)
@@ -1421,7 +1421,7 @@
     else if (vs->ds->surface->pf.bits_per_pixel == 8)
         vs->send_hextile_tile = send_hextile_tile_8;
     vs->clientds = *(vs->ds->surface);
-    vs->clientds.flags |= ~QEMU_ALLOCATED_FLAG;
+    vs->clientds.flags &= ~QEMU_ALLOCATED_FLAG;
     vs->write_pixels = vnc_write_pixels_copy;
 
     vnc_write(vs, pad, 3);           /* padding */

--------------020406030206020905030803--