From: Hans de Goede <hdegoede@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] PATCH; sensors-detect: do not crash FSC Syleus IC's
Date: Sat, 14 Feb 2009 19:12:32 +0000 [thread overview]
Message-ID: <499717A0.6070002@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
Hi,
As discussed on IRC the Syleus does not like our way of seeing if a device is
present at a certain address, this patch implements a workaround consisting of
doing a byte data read instead of a quick command or a byte read.
Once reviewed I can commit this myself.
Regards,
Hans
[-- Attachment #2: sensors-detect-dont-crash-syleus.patch --]
[-- Type: text/plain, Size: 885 bytes --]
Index: prog/detect/sensors-detect
===================================================================
--- prog/detect/sensors-detect (revision 5642)
+++ prog/detect/sensors-detect (working copy)
@@ -2629,7 +2629,14 @@
{
my ($file, $addr, $funcs) = @_;
- if (($addr >= 0x50 && $addr <= 0x5F)
+ if ($addr == 0x73) {
+ # Special case for FSC chips, as at least the Syleus locks
+ # up with our regular probe code. Note that to our current
+ # knowledge only FSC chips live on this address, and for them
+ # this probe method is safe
+ return 0 unless ($funcs & I2C_FUNC_SMBUS_READ_BYTE);
+ return i2c_smbus_access($file, SMBUS_READ, 0, SMBUS_BYTE_DATA, []);
+ } elsif (($addr >= 0x50 && $addr <= 0x5F)
|| ($addr >= 0x30 && $addr <= 0x37)) {
# This covers all EEPROMs we know of, including page protection
# addresses. Note that some page protection addresses will not
[-- Attachment #3: Type: text/plain, Size: 153 bytes --]
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2009-02-14 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 19:12 Hans de Goede [this message]
2009-02-18 16:23 ` [lm-sensors] PATCH; sensors-detect: do not crash FSC Syleus IC's Jean Delvare
2009-02-18 18:33 ` Hans de Goede
2009-02-18 19:10 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499717A0.6070002@redhat.com \
--to=hdegoede@redhat.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.