From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LYSHn-00047u-H2
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 16:42:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LYSHm-00047i-2Q
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 16:42:54 -0500
Received: from [199.232.76.173] (port=50252 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LYSHl-00047f-U8
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 16:42:53 -0500
Received: from webaccess.egenera.com ([63.139.209.15]:50467)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <bkress@egenera.com>) id 1LYSHl-00006n-KB
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 16:42:53 -0500
Message-ID: <499735B3.3020401@egenera.com>
Date: Sat, 14 Feb 2009 16:20:51 -0500
From: Brian Kress <bkress@egenera.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix incorrect attempt to clear a flag in
	vnc.c
References: <4996BD8A.2050807@moose.net> <49973240.2070106@codemonkey.ws>
In-Reply-To: <49973240.2070106@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori wrote:
> Brian Kress wrote:
>> In vnc.c in pixel_format_message, the code tries to clear the 
>> QEMU_ALLOCATED_FLAG
>> from the client display surface, however it uses the wrong operator 
>> and ends up enabling all
>> other flags.  Most notably this enables the big endian flag and 
>> causes some chaos.
> Can you add a Signed-off-by line?
>
Signed-off-by: Brian Kress <kressb@moose.net>

Index: vnc.c
===================================================================
--- vnc.c	(revision 6619)
+++ vnc.c	(working copy)
@@ -1421,7 +1421,7 @@
     else if (vs->ds->surface->pf.bits_per_pixel == 8)
         vs->send_hextile_tile = send_hextile_tile_8;
     vs->clientds = *(vs->ds->surface);
-    vs->clientds.flags |= ~QEMU_ALLOCATED_FLAG;
+    vs->clientds.flags &= ~QEMU_ALLOCATED_FLAG;
     vs->write_pixels = vnc_write_pixels_copy;
 
     vnc_write(vs, pad, 3);           /* padding */