From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: add "quick" group
Date: Sun, 15 Feb 2009 12:42:59 -0600 [thread overview]
Message-ID: <49986233.6050600@sandeen.net> (raw)
In-Reply-To: <20090215182153.GA31179@infradead.org>
Christoph Hellwig wrote:
> On Sat, Feb 14, 2009 at 01:58:24PM -0600, Eric Sandeen wrote:
>> Good plan, couple comments:
>>
>> should quick only be a subset auto tests or are they orthogonal?
>
> Just a subset of auto, yes.
>
>> A few tests you've flagged as quick don't met the 20s criteria on my
>> box, just FWIW; may be filesystem-size specific:
>>
>> 013 57
>
> We need this one for sure.
agreed
>> 028 23
>> 031 21
>> 049 36
>> 075 36
>> 076 56
>> 078 20
>> 091 26
>> 112 38
>> 113 55
>> 178 363
>>
>> Most are probably close enough, but 178 looks nasty - seems to be
>> xfs_repair that's taking so long. These are running on 100G partitions,
>> though :)
>
> 178 only takes 16 seconds for me, running on 10G partitions.
interesting that a 10x size growth makes a 22x time growth.
> I'm fine removing tests, and 178 would be the first candidate, maybe 076
> and 113, too.
Fine by me to leave them in, too, not a big deal - though maybe not 178.
Just wanted to point out that some of this is probably
fs-size-dependent. It'd be neat to have this somehow run based on
what's in the timestamp file, though that requires an initial seed.
I'd just drop 178 and call it good for now.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-02-15 18:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 16:42 [PATCH] xfstests: add "quick" group Christoph Hellwig
2009-02-14 19:58 ` Eric Sandeen
2009-02-15 18:21 ` Christoph Hellwig
2009-02-15 18:42 ` Eric Sandeen [this message]
2009-02-16 0:53 ` Mark Goodwin
2009-02-16 1:47 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49986233.6050600@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.