Re: [PATCH] netfilter: xtables: add cluster match

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> On Monday 2009-02-16 10:31, Pablo Neira Ayuso wrote:
> 
>> Pablo Neira Ayuso wrote:
>>
>>> +static int xt_cluster_seq_show(struct seq_file *s, void *v)
>>> +{
>>> +	unsigned long *mask = v;
>>> +	seq_printf(s, "0x%8lx\n", *mask);
>>                         ^^^
>> Damn, this needs the dot before the 8 to fill with zero the empty
>> spaces. Jan's suggestion was wrong and I forgot to check this. I'll send
>> the patch again.
> 
> Wait wait, let me requote myself:
> 
>> '.' does not make sense with non-string,non-floating point numbers 
>> (though it is a stdc feature it seems). I'd say "0x%08lx", for clarity.
> 
> The second '0' in "0x%08lx" is missing.

Lets discuss the need for this interface first before fixing it :)
It looks like a way to get around using (potentially slow) rule
replacement, which doesn't make sense to add on a per-module base.