From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Date: Mon, 16 Feb 2009 14:04:28 +0000 Subject: Re: [PATCH] wusb: Storage class should be before const qualifier Message-Id: <4999726C.3070706@csr.com> List-Id: References: <20090209220735.GA8082@xenon.distanz.ch> In-Reply-To: <20090209220735.GA8082@xenon.distanz.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Jiri Kosina wrote: > On Mon, 9 Feb 2009, Tobias Klauser wrote: > >> The C99 specification states in section 6.11.5: >> >> The placement of a storage-class specifier other than at the beginning >> of the declaration specifiers in a declaration is an obsolescent >> feature. >> >> Signed-off-by: Tobias Klauser >> --- >> include/linux/usb/wusb.h | 3 +-- >> 1 files changed, 1 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/usb/wusb.h b/include/linux/usb/wusb.h >> index 5f401b6..429c631 100644 >> --- a/include/linux/usb/wusb.h >> +++ b/include/linux/usb/wusb.h >> @@ -80,8 +80,7 @@ struct wusb_ckhdid { >> u8 data[16]; >> } __attribute__((packed)); >> >> -const static >> -struct wusb_ckhdid wusb_ckhdid_zero = { .data = { 0 } }; >> +static const struct wusb_ckhdid wusb_ckhdid_zero = { .data = { 0 } }; >> >> #define WUSB_CKHDID_STRSIZE (3 * sizeof(struct wusb_ckhdid) + 1) > > David, are you going to take this through wusb tree, or should I take it > through trivial tree together with the rest of these patches? I don't seem > to see this present in current -next. Through trivial is best I think, thanks. You can add Acked-by: David Vrabel if you wish. David -- David Vrabel, Senior Software Engineer, Drivers CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562 Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/