From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix hardware accelerated video to video copy on Cirrus VGA
Date: Mon, 16 Feb 2009 08:59:28 -0600 [thread overview]
Message-ID: <49997F50.9020608@us.ibm.com> (raw)
In-Reply-To: <49979F23.6010500@moose.net>
Brian Kress wrote:
> cirrus_do_copy() in hw/cirrus_vga.c seems to make some incorrect
> assumptions about video
> memory layout. It tries to convert addresses to coordinates assuming
> that one row of data is
> (width * depth) bytes long. The correct way seems to be to use the
> pitch fields in the
> CirrusVGAState structure instead.
> Without this patch, I get lots of screen corruption when I try to
> drag a window under X as it's
> passing the wrong coordinates to the display surface for the copy.
> With this patch I can drag a
> window with no screen corruption.
Applied. Thanks.
Regards,
Anthony Liguori
prev parent reply other threads:[~2009-02-16 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 4:50 [Qemu-devel] [PATCH] Fix hardware accelerated video to video copy on Cirrus VGA Brian Kress
2009-02-15 5:23 ` C.W. Betts
2009-02-15 5:23 ` C.W. Betts
2009-02-16 14:59 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49997F50.9020608@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.