From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LZBeS-0002vu-5C for qemu-devel@nongnu.org; Mon, 16 Feb 2009 17:09:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LZBeQ-0002sw-LR for qemu-devel@nongnu.org; Mon, 16 Feb 2009 17:09:19 -0500 Received: from [199.232.76.173] (port=49389 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LZBeQ-0002sq-HR for qemu-devel@nongnu.org; Mon, 16 Feb 2009 17:09:18 -0500 Received: from smtprelay0049.hostedemail.com ([216.40.44.49]:33983 helo=smtprelay.hostedemail.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LZBeQ-00063y-4P for qemu-devel@nongnu.org; Mon, 16 Feb 2009 17:09:18 -0500 Received: from filter.hostedemail.com (ff-bigip1 [10.5.19.254]) by smtprelay01.hostedemail.com (Postfix) with SMTP id 62290C80E42 for ; Mon, 16 Feb 2009 22:09:17 +0000 (UTC) Received: from [192.168.2.184] (cpe-66-66-167-50.rochester.res.rr.com [66.66.167.50]) (Authenticated sender: kressb@moose.net) by omf03.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Feb 2009 22:09:16 +0000 (UTC) Message-ID: <4999E40A.9070304@moose.net> Date: Mon, 16 Feb 2009 17:09:14 -0500 From: Brian Kress MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040809050302060707050407" Subject: [Qemu-devel] [PATCH] Missing cirrus_invalidate_region() in cirrus_do_copy() Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------040809050302060707050407 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit After doing a video to video copy, cirrus_do_copy() in cirrus_vga.c does a conditional call to cirrus_invalidate_region() with an "if (!notify)" test. However at this point the blt has already been done so it seems like this call should be made unconditionally. The patch below fixes some display update problems when dragging windows under both X (fedora 10 guest) and a Windows XP guest. --------------040809050302060707050407 Content-Type: text/plain; name="patch.cirrus_vga_invalidate" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch.cirrus_vga_invalidate" Signed-off-by: Brian Kress Index: hw/cirrus_vga.c =================================================================== --- hw/cirrus_vga.c (revision 6626) +++ hw/cirrus_vga.c (working copy) @@ -781,10 +781,9 @@ /* we don't have to notify the display that this portion has changed since qemu_console_copy implies this */ - if (!notify) - cirrus_invalidate_region(s, s->cirrus_blt_dstaddr, - s->cirrus_blt_dstpitch, s->cirrus_blt_width, - s->cirrus_blt_height); + cirrus_invalidate_region(s, s->cirrus_blt_dstaddr, + s->cirrus_blt_dstpitch, s->cirrus_blt_width, + s->cirrus_blt_height); } static int cirrus_bitblt_videotovideo_copy(CirrusVGAState * s) --------------040809050302060707050407--