From: Jeff Garzik <jgarzik@pobox.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
alan@lxorguk.ukuu.org.uk, rjw@sisk.pl, akpm@linux-foundation.org
Subject: Re: [PATCH 1/2] libata-sff: fix 32-bit PIO ATAPI regression
Date: Mon, 16 Feb 2009 18:56:10 -0500 [thread overview]
Message-ID: <4999FD1A.3080407@pobox.com> (raw)
In-Reply-To: <200902152224.25144.sshtylyov@ru.mvista.com>
Sergei Shtylyov wrote:
> Commit 871af1210f13966ab911ed2166e4ab2ce775b99d (libata: Add 32bit PIO support)
> has caused all kinds of errors on the ATAPI devices, so it has been empirically
> proven that one shouldn't try to read/write an extra data word when a device is
> not expecting it already. "Don't do it then"; however, still use a chance to do
> 32-bit read/write one last time when there are exactly 3 trailing bytes.
>
> Oh, and stop pointlessly swapping the bytes to and fro on big-endian machines
> by using io*_rep() accessors which shouldn't byte-swap.
>
> This patch should fix the kernel.org bug #12609.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> Added the comments and signoff.
> The patch is against the recent Linus' tree.
> It's a hopefully better replacement for Hugh Dickins most recent patch
> (http://marc.info/?l=linux-ide&m=123352294619281)...
applied, much appreciated!
next prev parent reply other threads:[~2009-02-16 23:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 19:24 [PATCH 1/2] libata-sff: fix 32-bit PIO ATAPI regression Sergei Shtylyov
2009-02-16 23:56 ` Jeff Garzik [this message]
2009-02-17 0:20 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4999FD1A.3080407@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.