From: Roel Kluin <roel.kluin@gmail.com>
To: avi@redhat.com
Cc: kvm@vger.kernel.org, jvpeetz@web.de,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] kvm: ||/&& typo
Date: Tue, 17 Feb 2009 15:49:15 +0100 [thread overview]
Message-ID: <499ACE6B.6020407@gmail.com> (raw)
This was also reported by Jörg-Volker Peetz here:
http://lkml.org/lkml/2009/2/16/325
------------------->8---------------------8<-----------------------
Since ss.type is always either not 3 or not 7.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 6259d74..7c4cca1 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -1813,7 +1813,7 @@ static bool stack_segment_valid(struct kvm_vcpu *vcpu)
vmx_get_segment(vcpu, &ss, VCPU_SREG_SS);
ss_rpl = ss.selector & SELECTOR_RPL_MASK;
- if ((ss.type != 3) || (ss.type != 7))
+ if ((ss.type != 3) && (ss.type != 7))
return false;
if (!ss.s)
return false;
next reply other threads:[~2009-02-17 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 14:49 Roel Kluin [this message]
2009-02-17 15:16 ` [PATCH] kvm: ||/&& typo Roel Kluin
2009-02-17 18:16 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499ACE6B.6020407@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=jvpeetz@web.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.