Re: [PATCH] kvm: userspace: Initialise ECX value with 'count' as host_cpuid now expects it

[Avi Kivity <avi@redhat.com>]

Amit Shah wrote:
> host_cpuid now accepts a 'count' parameter for cpuid. Initialise the value
> of ecx before any call to the function.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>  qemu/qemu-kvm-x86.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/qemu/qemu-kvm-x86.c b/qemu/qemu-kvm-x86.c
> index 5264015..b1e2da2 100644
> --- a/qemu/qemu-kvm-x86.c
> +++ b/qemu/qemu-kvm-x86.c
> @@ -534,6 +534,7 @@ int kvm_arch_qemu_init_env(CPUState *cenv)
>  #endif
>  
>      copy.regs[R_EAX] = 0;
> +    copy.regs[R_ECX] = 0;
>      qemu_kvm_cpuid_on_env(&copy);
>      limit = copy.regs[R_EAX];
>  
> @@ -559,6 +560,7 @@ int kvm_arch_qemu_init_env(CPUState *cenv)
>      }
>  
>      copy.regs[R_EAX] = 0x80000000;
> +    copy.regs[R_ECX] = 0;
>      qemu_kvm_cpuid_on_env(&copy);
>      limit = copy.regs[R_EAX]; 
>   

Does this make any difference?  Neither function actually depends on ecx.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.