From: "H. Peter Anvin" <hpa@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/headers] x86: truncate ISA addresses to unsigned int
Date: Tue, 17 Feb 2009 13:25:51 -0800 [thread overview]
Message-ID: <499B2B5F.2070407@linux.intel.com> (raw)
In-Reply-To: <1234905865.23466.11.camel@localhost.localdomain>
James Bottomley wrote:
>> +static inline unsigned int isa_virt_to_bus(volatile void *address)
>
> The rest looks fine, but why is the address volatile? The macro below
> never actually dereferences it.
>
Because a volatile is permitted. virt_to_phys() takes a volatile
pointer for that reason.
-hpa
next prev parent reply other threads:[~2009-02-17 21:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-a7eb518998529c08cc53fef17756d9fe433b0c23@kernel.org>
2009-02-17 21:24 ` [tip:x86/headers] x86: truncate ISA addresses to unsigned int James Bottomley
2009-02-17 21:25 ` H. Peter Anvin [this message]
2009-02-17 21:55 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499B2B5F.2070407@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.