From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: Re: pv_ops parport trouble Date: Thu, 19 Feb 2009 17:31:38 +0100 Message-ID: <499D896A.5050202@redhat.com> References: <499D878F.4070906@goop.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060607090004060005050704" Return-path: In-Reply-To: <499D878F.4070906@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: Xen Development Mailing List , Keir Fraser List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------060607090004060005050704 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Jeremy Fitzhardinge wrote: > I guess that's possible, but the code in question does just pass the > trigger and polarity straight through. Notice: #define ACPI_LEVEL_SENSITIVE (u8) 0x00 whereas for the io apic 0 == edge. cheers, Gerd --------------060607090004060005050704 Content-Type: text/plain; name="fix" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fix" diff --git a/arch/x86/xen/pci.c b/arch/x86/xen/pci.c index d661c74..62ab389 100644 --- a/arch/x86/xen/pci.c +++ b/arch/x86/xen/pci.c @@ -53,7 +53,7 @@ int xen_register_gsi(u32 gsi, int triggering, int polarity) printk(KERN_DEBUG "xen: --> irq=%d\n", irq); if (irq > 0) - xen_set_io_apic_routing(irq, triggering, polarity); + xen_set_io_apic_routing(irq, triggering == ACPI_LEVEL_SENSITIVE, polarity); return irq; } --------------060607090004060005050704 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------060607090004060005050704--