From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM:OMAP3 Change mmc_init to mmc_legacy_init
Date: Thu, 19 Feb 2009 20:22:47 -0600 [thread overview]
Message-ID: <499E13F7.6020909@windriver.com> (raw)
In-Reply-To: <20090219230739.879A3832E43F@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Tom,
>
> in message <20090219225148.01866832E43F@gemini.denx.de> I wrote:
>
>>> omap3_mmc.c was changed to define mmc_legacy_init.
>>> Remove unused functions.
>>>
>>> Compile tested on all arm
>>> Runtime tested on Zoom1.
>>>
>>> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
>>> ---
>>> drivers/mmc/omap3_mmc.c | 17 ++---------------
>>> 1 files changed, 2 insertions(+), 15 deletions(-)
>>>
>> Applied, thanks.
>>
>
> ...but there are still build errors on ARM:
>
> Configuring for cerf250 board...
> In file included from mmc.c:31:
> mmc.h:139: error: redefinition of 'struct mmc_cid'
> mmc.h:151: error: redefinition of 'struct mmc_csd'
>
The recent patches I posted should fix this problems.
They appear to be only in pxa.
The changes looked obvious.
MAKEBUILDALL arm and grep-ing for mmc in the *.ERR file were used to
test the compile.
I do not have a pxa target so I was unable to do a runtime test.
It would be a good idea for someone with a pxa board like cerf250 to
test these changes.
Tom
next prev parent reply other threads:[~2009-02-20 2:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 22:45 [U-Boot] [PATCH] ARM:OMAP3 Change mmc_init to mmc_legacy_init Tom Rix
2009-02-19 22:51 ` Wolfgang Denk
2009-02-19 23:07 ` Wolfgang Denk
2009-02-20 0:48 ` Tom
2009-02-20 2:22 ` Tom [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-19 16:50 Tom Rix
2009-02-19 17:22 ` Dirk Behme
2009-02-19 20:25 ` Dirk Behme
2009-02-19 21:51 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499E13F7.6020909@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.