From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] ioemu : add flush in ide_unplug_harddisks()
Date: Fri, 20 Feb 2009 11:40:03 +0000
Message-ID: <499E9693.3060708@eu.citrix.com>
References: <81C9930B79FFCBt.horikoshi@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <81C9930B79FFCBt.horikoshi@jp.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tomonari Horikoshi <t.horikoshi@jp.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Tomonari Horikoshi wrote:

> Hi
> 
> I think the "flush" is necessary. 
> When "ioemu ide device" changes into "vbd" by "ide_unplug_harddisks()". 
> 
> What do you think?
> 
> 

I don't think that calling bdrv_aio_flush is a good idea since it is
asyncronous and right after the call we are going to close the device
without waiting for completion.