All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roel Kluin <roel.kluin@gmail.com>
To: mingo@redhat.com
Cc: lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] IA64: cast has a higher precedence than '?'
Date: Fri, 20 Feb 2009 13:05:05 +0100	[thread overview]
Message-ID: <499E9C71.3050003@gmail.com> (raw)

because of the ?: this is not strictly necessary, but I think the added
parentheses are nice here.

--------------------------->8-------------8<------------------------------
A cast has a higher precedence than '?'

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/x86/include/asm/syscall.h b/arch/x86/include/asm/syscall.h
index d82f39b..b8a1933 100644
--- a/arch/x86/include/asm/syscall.h
+++ b/arch/x86/include/asm/syscall.h
@@ -61,7 +61,7 @@ static inline void syscall_set_return_value(struct task_struct *task,
 					    struct pt_regs *regs,
 					    int error, long val)
 {
-	regs->ax = (long) error ?: val;
+	regs->ax = (long) (error ?: val);
 }
 
 #ifdef CONFIG_X86_32

             reply	other threads:[~2009-02-20 12:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20 12:05 Roel Kluin [this message]
2009-02-20 12:37 ` [PATCH] IA64: cast has a higher precedence than '?' Ingo Molnar
2009-02-20 12:37 ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2009-02-20 11:52 Roel Kluin
2009-02-20 12:50 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499E9C71.3050003@gmail.com \
    --to=roel.kluin@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.