Re: [gkernel-commit] [PATCH 2/3] [kernel] Add support for RX packet classification in a network device

[Santwona.Behera@Sun.COM]

Hi Dave,

I actually did make the changes and compile with sparse (without any 
warnings, at least for the access of these fields), but I haven't had 
the time to test it yet, which is why I did not post the new patches.

Thanks for taking care of it.

--santwona

On 02/20/09 12:55 AM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 17 Feb 2009 20:28:38 -0800 (PST)
> 
>> From: Santwona.Behera@Sun.COM
>> Date: Mon, 16 Feb 2009 09:17:23 -0800
>>
>>> -struct ethtool_rxnfc {
>>> -	__u32		cmd;
>>> +/* The following structures are for supporting RX network flow
>>> + * classification configuration. Note, all multibyte fields, e.g.,
>>> + * ip4src, ip4dst, psrc, pdst, spi, etc. are expected to be in network
>>> + * byte order.
>>> + */
>>> +struct ethtool_tcpip4_spec {
>>> +	__u32	ip4src;
>>> +	__u32	ip4dst;
>>> +	__u16	psrc;
>>> +	__u16	pdst;
>>> +	__u8    tos;
>>> +};
>> We have specific types for this, "__be32" et al.
> 
> Nevermind, you obviously don't have time to get to this quickly
> so I'll take care of it while checking this stuff in...
>