From: Li Zefan <lizf@cn.fujitsu.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org,
Stephen Hemminger <shemminger@linux-foundation.org>,
Paul Jackson <pj@sgi.com>, Simon Derr <simon.derr@bull.net>,
Paul Menage <menage@google.com>
Subject: Re: [PATCH] Remove some pointless conditionals before kfree() in kernel/cgroup.c
Date: Mon, 23 Feb 2009 16:32:48 +0800 [thread overview]
Message-ID: <49A25F30.9060305@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.LNX.2.00.0902222254350.1236@swampdragon.chaosbits.net>
Jesper Juhl wrote:
> Hi,
>
> Here's a small patch for kernel/cgroup.c
>
> Removes a few pointless tests of pointer == 0 before kfree() in
> kernel/cgroup.c.
> If the pointer we hand to kfree() is 0, then kfree() is a noop, so there
> is no need to test.
>
> Reduces object file size a bit :
>
> Before:
> $ size kernel/cgroup.o
> text data bss dec hex filename
> 21593 7804 4924 34321 8611 kernel/cgroup.o
> After:
> $ size kernel/cgroup.o
> text data bss dec hex filename
> 21537 7744 4924 34205 859d kernel/cgroup.o
>
> and source file size shrinks a bit too - always nice.
>
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>
prev parent reply other threads:[~2009-02-23 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-22 22:05 [PATCH] Remove some pointless conditionals before kfree() in kernel/cgroup.c Jesper Juhl
2009-02-23 8:12 ` Paul Menage
2009-02-23 8:17 ` Cyrill Gorcunov
2009-02-23 8:19 ` Cyrill Gorcunov
2009-02-23 8:30 ` Li Zefan
2009-02-23 21:46 ` Jesper Juhl
2009-02-23 8:32 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A25F30.9060305@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=pj@sgi.com \
--cc=shemminger@linux-foundation.org \
--cc=simon.derr@bull.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.