From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LbWdY-0008Mo-8E for mharc-grub-devel@gnu.org; Mon, 23 Feb 2009 03:58:04 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LbWdW-0008JM-Bh for grub-devel@gnu.org; Mon, 23 Feb 2009 03:58:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LbWdV-0008IY-Q2 for grub-devel@gnu.org; Mon, 23 Feb 2009 03:58:02 -0500 Received: from [199.232.76.173] (port=57254 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LbWdV-0008IN-ML for grub-devel@gnu.org; Mon, 23 Feb 2009 03:58:01 -0500 Received: from mail-fx0-f174.google.com ([209.85.220.174]:42256) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LbWdV-00018A-8d for grub-devel@gnu.org; Mon, 23 Feb 2009 03:58:01 -0500 Received: by mail-fx0-f174.google.com with SMTP id 22so1507924fxm.18 for ; Mon, 23 Feb 2009 00:58:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type; bh=JuizQHPGZYrG8xgJO/YS1u7O/ZA2XEwEC8TkJq2qqqc=; b=soi2cNRcxLJhql8aEhy20pXaVJ8RprpYugwSbiNTxqEWQvIuXZTPua+ehrii/wedIy c6jwovjAOpNBg/he3w5+utOk0Ib6FeSVbV12Xr5mQzDZft3yCseOUXfcCirY/puHb39t WO6YoMmz0FGrgfKOmAtSDNBcZ+8r44GVlmIlo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; b=Bc3vGcfNkB89MYNcJ8E/jEdvANMGvOpIHeT6Z8nrdpyHGJ3M55tfDAUOb1lO5bdJmX CTLiPFcKS5lAnsFk3XlDwp0Wn1NMqaKaRav8rkpz385oCe3m7LVuPcn5FCJqG7vabHZA ImuKdYpdLsSWGbfjUg0asp8Tefj2sO8eAi6aw= Received: by 10.223.122.15 with SMTP id j15mr4451676far.10.1235379480838; Mon, 23 Feb 2009 00:58:00 -0800 (PST) Received: from ?82.130.80.231? (hg-public-dock-231-dhcp.ethz.ch [82.130.80.231]) by mx.google.com with ESMTPS id 22sm8845871fkr.34.2009.02.23.00.57.59 (version=SSLv3 cipher=RC4-MD5); Mon, 23 Feb 2009 00:58:00 -0800 (PST) Message-ID: <49A26517.5050106@gmail.com> Date: Mon, 23 Feb 2009 09:57:59 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 Content-Type: multipart/mixed; boundary="------------030402020001080902010109" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Minor leak in scsi.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Feb 2009 08:58:02 -0000 This is a multi-part message in MIME format. --------------030402020001080902010109 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hello. Here is a fix for a leak I found when debugging grub-emu with valgrind Regards Vladimir 'phcoder' Serbinenko --------------030402020001080902010109 Content-Type: text/x-patch; name="scsi.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="scsi.patch" Index: ChangeLog =================================================================== --- ChangeLog (revision 1999) +++ ChangeLog (working copy) @@ -1,3 +1,120 @@ +2009-02-23 Vladimir Serbinenko + + Don't leak in SCSI code + + * disk/scsi.c (grub_scsi_close): free scsi + +2009-02-13 Vladimir Serbinenko + + Test command + + * commands/test.c: rewritten to use bash-like test + * include/grub/fs.h (struct grub_dirhook_info): new field + case_insensitive + * fs/hfsplus.c: declare FS as case-insensitive if necessary + * fs/fat.c: likewise + +2009-02-12 Vladimir Serbinenko + + Support for mtime and further expandability of dir command + + * include/grub/lib/datetime.h: moved to ... + * include/grub/datetime.h: ... moved here and added + declaration of grub_unixtime2datetime. All users updated + * include/grub/fs.h: new syntax for dir and mtime functionin + struct grub_fs + * include/grub/fshelp.h: new declarations of GRUB_FSHELP_TYPE_MASK + and GRUB_FSHELP_FLAGS_MASK + * commands/ls.c (grub_ls_list_files): Write mtime in long format + * fs/ext2.c (grub_ext2_dir): use new dir syntax and supply mtime + (grub_ext2_mtime): new function + * fs/affs.c (grub_affs_dir): use new dir syntax + * fs/afs.c (grub_afs_dir): likewise + * fs/cpio.c (grub_cpio_dir): likewise + * fs/fat.c (grub_fat_find_dir): likewise + * fs/hfs.c (grub_hfs_dir): likewise + * fs/hfsplus.c (grub_hfsplus_dir): likewise + * fs/iso9660.c (grub_iso9660_dir): likewise + * fs/jfs.c (grub_jfs_dir): likewise + * fs/minix.c (grub_minix_dir): likewise + * fs/ntfs.c (grub_ntfs_dir): likewise + * fs/reiserfs.c (grub_reiserfs_dir): likewise + * fs/sfs.c (grub_sfs_dir): likewise + * fs/xfs.c (grub_xfs_dir): likewise + * fs/ufs.c (grub_ufs_dir): likewise + * util/hostfs.c (grub_hostfs_dir): likewise + * lib/datetime.c: moved to ... + * normal/datetime.c: ... moved here + (grub_unixtime2datetime): new function + * kern/rescue.c (grub_rescue_print_files): use new dir syntax + * normal/completition.c (iterate_dir): use new dir syntax + * normal/misc.c (grub_normal_print_device_info): tell the + last modification time of a volume + * kern/fs.c (grub_fs_probe): updated dummy function to use new syntax + * conf/common.rmk: added lib/datetime.c to ls.mod + * conf/i386-coreboot.rmk: added normal/datetime.c to grub-emu + and normal.mod. Removed lib/datetime.c from datetime.mod + * conf/i386-efi.rmk: likewise + * conf/i386-ieee1275.rmk: likewise + * conf/i386-pc.rmk: likewise + * conf/powerpc-ieee1275.rmk: likewise + * conf/sparc64-ieee1275.rmk: likewise + * conf/x86_64-efi.rmk: likewise + +2009-02-11 Vladimir Serbinenko + + New command: "activate" replacement for makeactive of grub1 + + * commands/i386/pc/activate.c: new file + * conf/i386-pc.rmk: new module activate.mod + add commands/i386/pc/activate.c to grub-emu sources + +2009-02-11 Vladimir Serbinenko + + Trim trailing spaces in FAT label and support mtools-like labels + + * fs/fat.c (grub_fat_iterate_dir): New function based + on grub_fat_find_dir + (grub_fat_find_dir): use grub_fat_iterate_dir + (grub_fat_label): likewise + +2009-02-09 Vladimir Serbinenko + + Bugfix: directories not reported as such on case-insensitive hfs+ + + * include/grub/fshelp.h: included definition of GRUB_FSHELP_TYPE_MASK + and GRUB_FSHELP_FLAGS_MASK + * fs/hfsplus.c (grub_hfsplus_dir): ignore filetype flags + +2009-02-09 Vladimir Serbinenko + + Bugfix: directories not reported as such on case-insensitive hfs+ + + * include/grub/fshelp.h: included definition of GRUB_FSHELP_TYPE_MASK + and GRUB_FSHELP_FLAGS_MASK + * fs/hfsplus.c (grub_hfsplus_dir): ignore filetype flags + +2009-02-07 Vladimir Serbinenko + + Redraw character so it doesn't disappear after cursor moves from it + + * term/gfterm.c (draw_cursor): Redraw character so it + doesn't disappear after cursor moves from it + (GRUB_MOD_FINI): correct the name of the command + +2009-02-04 Vladimir Serbinenko + + Remove trailing spaces from FAT label + + * fs/fat.c (grub_fat_label): Remove trailing spaces + +2009-02-04 Vladimir Serbinenko + + Add prefix option for grub-setup + + * util/i386/pc/grub-setup.c (main): Add -p option. + (setup): additional argument prefix_dir + 2009-02-22 Robert Millan * include/multiboot.h (MULTIBOOT_INFO_ALIGN): New macro. Index: disk/scsi.c =================================================================== --- disk/scsi.c (revision 1999) +++ disk/scsi.c (working copy) @@ -312,7 +312,8 @@ grub_scsi_t scsi; scsi = disk->data; - return scsi->dev->close (scsi); + scsi->dev->close (scsi); + grub_free (scsi); } static grub_err_t --------------030402020001080902010109--