From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH] hdparm: Show form factor and media rotation rate Date: Mon, 23 Feb 2009 15:26:30 -0500 Message-ID: <49A30676.4090906@rtr.ca> References: <49A08310.8020100@msgid.tls.msk.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([76.10.145.34]:53764 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753325AbZBWU0e (ORCPT ); Mon, 23 Feb 2009 15:26:34 -0500 In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: "Martin K. Petersen" Cc: Michael Tokarev , linux-ide@vger.kernel.org Martin K. Petersen wrote: >>>>>> "Michael" == Michael Tokarev writes: > > Michael> How about printing the actual (unrecognized) value here? Like > Michael> this: > > Michael> + default: > Michael> + printf("unknown (raw value = %d)", val[FORM_FACTOR]); > Michael> + break; > > I'm ok with that. Mark? .. Already done, except in hex. Cheers